diff mbox

[net-next] netfilter: nfnetlink_queue: fix compilation problem due missing header

Message ID 1389026089-4917-1-git-send-email-pablo@netfilter.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Pablo Neira Ayuso Jan. 6, 2014, 4:34 p.m. UTC
In 08c0cad ("netfilter: nfnetlink_queue: enable UID/GID socket info
retrieval"), the header that defines TCP_TIME_WAIT.

net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid':
net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function)
net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
Hi David,

Please, put this patch into net-next. It seems this compilation problem is
depending on the .config selections as I didn't reproducible when testing the
patches.

Thanks!

 net/netfilter/nfnetlink_queue_core.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Eric Dumazet Jan. 6, 2014, 4:52 p.m. UTC | #1
On Mon, 2014-01-06 at 17:34 +0100, Pablo Neira Ayuso wrote:
> In 08c0cad ("netfilter: nfnetlink_queue: enable UID/GID socket info
> retrieval"), the header that defines TCP_TIME_WAIT.
> 
> net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid':
> net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function)
> net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1
> 
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---

Tested-by: Eric Dumazet <edumazet@google.com>

Thanks Pablo !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index d3cf12b..ce20bd8 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -32,6 +32,7 @@ 
 #include <net/netfilter/nf_queue.h>
 #include <net/netns/generic.h>
 #include <net/netfilter/nfnetlink_queue.h>
+#include <net/tcp_states.h>
 
 #include <linux/atomic.h>