Message ID | 1388982699-11514-1-git-send-email-linux@roeck-us.net |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Guenter Roeck <linux@roeck-us.net> Date: Sun, 5 Jan 2014 20:31:39 -0800 > With arm:allmodconfig, building the Teles PCI driver fails with > > telespci.c:294:2: error: #error "not running on big endian machines now" > > Similar, building the driver for HFC PCI-Bus cards fails with > > hfc_pci.c:1647:2: error: #error "not running on big endian machines now" > > Remove the big endian cpp check from both drivers to fix the build errors. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/isdn/hisax/hfc_pci.c b/drivers/isdn/hisax/hfc_pci.c index 497bd02..4a48255 100644 --- a/drivers/isdn/hisax/hfc_pci.c +++ b/drivers/isdn/hisax/hfc_pci.c @@ -1643,10 +1643,6 @@ setup_hfcpci(struct IsdnCard *card) int i; struct pci_dev *tmp_hfcpci = NULL; -#ifdef __BIG_ENDIAN -#error "not running on big endian machines now" -#endif - strcpy(tmp, hfcpci_revision); printk(KERN_INFO "HiSax: HFC-PCI driver Rev. %s\n", HiSax_getrev(tmp)); diff --git a/drivers/isdn/hisax/telespci.c b/drivers/isdn/hisax/telespci.c index f6ab63a..33eeb46 100644 --- a/drivers/isdn/hisax/telespci.c +++ b/drivers/isdn/hisax/telespci.c @@ -290,10 +290,6 @@ int setup_telespci(struct IsdnCard *card) struct IsdnCardState *cs = card->cs; char tmp[64]; -#ifdef __BIG_ENDIAN -#error "not running on big endian machines now" -#endif - strcpy(tmp, telespci_revision); printk(KERN_INFO "HiSax: Teles/PCI driver Rev. %s\n", HiSax_getrev(tmp)); if (cs->typ != ISDN_CTYPE_TELESPCI)
With arm:allmodconfig, building the Teles PCI driver fails with telespci.c:294:2: error: #error "not running on big endian machines now" Similar, building the driver for HFC PCI-Bus cards fails with hfc_pci.c:1647:2: error: #error "not running on big endian machines now" Remove the big endian cpp check from both drivers to fix the build errors. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- v3: Instead of marking build as broken, remove cpp endianness checks. Updated headline to match the changes. v2: Turns out CPU_LITTLE_ENDIAN is not defined for little-endian-only architectures. Instead of messing with the overall Kconfig architecture, mark build as broken for big endian ARM machines. Also updated headline accordingly. drivers/isdn/hisax/hfc_pci.c | 4 ---- drivers/isdn/hisax/telespci.c | 4 ---- 2 files changed, 8 deletions(-)