From patchwork Sun Jan 5 18:02:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 307006 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 505AC2C00AC for ; Mon, 6 Jan 2014 05:04:13 +1100 (EST) Received: from localhost ([::1]:58912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzs3W-0007vy-K9 for incoming@patchwork.ozlabs.org; Sun, 05 Jan 2014 13:04:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzs1E-0004vQ-EU for qemu-devel@nongnu.org; Sun, 05 Jan 2014 13:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vzs16-0004ps-PX for qemu-devel@nongnu.org; Sun, 05 Jan 2014 13:01:48 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:52775 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzs16-0004oD-CH for qemu-devel@nongnu.org; Sun, 05 Jan 2014 13:01:40 -0500 Received: (qmail 1294 invoked by uid 89); 5 Jan 2014 18:01:39 -0000 Received: from [82.141.1.145] by client-16-kamp (envelope-from , uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.98/18317. hbedv: 8.2.12.166/7.11.123.168. spamassassin: 3.3.1. Clear:RC:1(82.141.1.145):SA:0(-1.2/5.0):. Processed in 2.01614 secs); 05 Jan 2014 18:01:39 -0000 Received: from ns.kamp-intra.net (HELO dns.kamp-intra.net) ([82.141.1.145]) by mx01.kamp.de with SMTP; 5 Jan 2014 18:01:37 -0000 X-GL_Whitelist: yes Received: from lieven-pc.kamp-intra.net (lieven-pc.kamp-intra.net [172.21.12.60]) by dns.kamp-intra.net (Postfix) with ESMTP id 5F8C1206AD; Sun, 5 Jan 2014 19:00:55 +0100 (CET) Received: by lieven-pc.kamp-intra.net (Postfix, from userid 1000) id E6C035FD4C; Sun, 5 Jan 2014 19:02:32 +0100 (CET) From: Peter Lieven To: qemu-devel@nongnu.org Date: Sun, 5 Jan 2014 19:02:30 +0100 Message-Id: <1388944951-14767-6-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1388944951-14767-1-git-send-email-pl@kamp.de> References: <1388944951-14767-1-git-send-email-pl@kamp.de> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:248:0:51::16 Cc: sw@weilnetz.de, Peter Lieven , aliguori@amazon.com Subject: [Qemu-devel] [PATCHv3 5/6] ui/vnc: optimize setting in vnc_dpy_update() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Peter Lieven --- ui/vnc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 980df34..805c47a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -430,7 +430,6 @@ static int vnc_refresh_server_surface(VncDisplay *vd); static void vnc_dpy_update(DisplayChangeListener *dcl, int x, int y, int w, int h) { - int i; VncDisplay *vd = container_of(dcl, VncDisplay, dcl); struct VncSurface *s = &vd->guest; int width = surface_width(vd->ds); @@ -451,9 +450,8 @@ static void vnc_dpy_update(DisplayChangeListener *dcl, h = MIN(h, height); for (; y < h; y++) { - for (i = 0; i < w; i += VNC_DIRTY_PIXELS_PER_BIT) { - set_bit((x + i) / VNC_DIRTY_PIXELS_PER_BIT, s->dirty[y]); - } + bitmap_set(s->dirty[y], x / VNC_DIRTY_PIXELS_PER_BIT, + w / VNC_DIRTY_PIXELS_PER_BIT); } }