Patchwork address incompatible change of qemu-img

login
register
mail settings
Submitter Ryota OZAKI
Date Aug. 4, 2009, 2:43 a.m.
Message ID <5e93dcec0908031943n43ef28b8n77e70c6a470cd950@mail.gmail.com>
Download mbox | patch
Permalink /patch/30697/
State Superseded
Headers show

Comments

Ryota OZAKI - Aug. 4, 2009, 2:43 a.m.
Hi,

Latest qemu-img (maybe from 0.11.0-rc0 or later?) changes
default unit of size as bytes, it was kilo-bytes so far.
(see http://www.mail-archive.com/kvm@vger.kernel.org/msg19183.html)

This patch addresses this incompatibility by adding postfix
'K'. This fix is able to keep backward compatibility for
old qemu as well, and also even if qemu-img falls back old
style or any, this explicit specifying should work well.

Thanks,
  ozaki-r

From 7d3dd9e592deab5a1d793532cf230d8367372280 Mon Sep 17 00:00:00 2001
From: Ryota Ozaki <ozaki.ryota@gmail.com>
Date: Tue, 4 Aug 2009 11:11:31 +0900
Subject: [PATCH] address incompatible change of qemu-img

---
 src/storage_backend.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/src/storage_backend.c b/src/storage_backend.c
index 07a2e48..8824218 100644
--- a/src/storage_backend.c
+++ b/src/storage_backend.c
@@ -446,7 +446,7 @@  virStorageBackendCreateQemuImg(virConnectPtr conn,


     /* Size in KB */
-    snprintf(size, sizeof(size), "%llu", vol->capacity/1024);
+    snprintf(size, sizeof(size), "%lluK", vol->capacity/1024);

     if (virRun(conn, imgargv, NULL) < 0) {
         VIR_FREE(imgargv[0]);