Message ID | 20140105084547.GA2929@brian-ubuntu |
---|---|
State | RFC |
Headers | show |
On Sun, Jan 05, 2014 at 12:46:10AM -0800, Brian Norris wrote: > > Hmm, I'm seeing some issues with this patch. I think it's problematic > that you are changing MTD_BLKDEVS from tristate to bool. We can't have [..] > > I believe the correct solution would be the following additional diff: > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > index cdaa4e512c97..5ebcda39f554 100644 > --- a/drivers/mtd/Kconfig > +++ b/drivers/mtd/Kconfig > @@ -161,7 +161,7 @@ comment "User Modules And Translation Layers" > # MTD block device support is select'ed if needed > # > config MTD_BLKDEVS > - bool > + tristate > > config MTD_BLOCK > tristate "Caching block device access to MTD devices" > -- > > I'll squash this into your patch if I don't hear any objections. > The solution looks fine. Thanks for taking care of it.
On Sun, Jan 05, 2014 at 02:37:57PM -0300, Ezequiel Garcia wrote: > On Sun, Jan 05, 2014 at 12:46:10AM -0800, Brian Norris wrote: > > > > Hmm, I'm seeing some issues with this patch. I think it's problematic > > that you are changing MTD_BLKDEVS from tristate to bool. We can't have > [..] > > > > I believe the correct solution would be the following additional diff: > > > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > > index cdaa4e512c97..5ebcda39f554 100644 > > --- a/drivers/mtd/Kconfig > > +++ b/drivers/mtd/Kconfig > > @@ -161,7 +161,7 @@ comment "User Modules And Translation Layers" > > # MTD block device support is select'ed if needed > > # > > config MTD_BLKDEVS > > - bool > > + tristate > > > > config MTD_BLOCK > > tristate "Caching block device access to MTD devices" > > -- > > > > I'll squash this into your patch if I don't hear any objections. > > > > The solution looks fine. Thanks for taking care of it. OK, squahsed and pushed to l2-mtd.git. Brian
diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index cdaa4e512c97..5ebcda39f554 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -161,7 +161,7 @@ comment "User Modules And Translation Layers" # MTD block device support is select'ed if needed # config MTD_BLKDEVS - bool + tristate config MTD_BLOCK tristate "Caching block device access to MTD devices"