| Message ID | 1388870493-6523-1-git-send-email-wsa@the-dreams.de |
|---|---|
| State | Accepted |
| Headers | show |
On Wednesday 08 January 2014 22:21:33, Wolfram Sang wrote: > cppcheck rightfully says: > > drivers/i2c/busses/i2c-viperboard.c:169: style: Variable 'bytes_xfer' is > assigned a value that is never used. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- > drivers/i2c/busses/i2c-viperboard.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-viperboard.c > b/drivers/i2c/busses/i2c-viperboard.c index 6976e1c..7533fa3 100644 > --- a/drivers/i2c/busses/i2c-viperboard.c > +++ b/drivers/i2c/busses/i2c-viperboard.c > @@ -118,8 +118,7 @@ static int vprbrd_i2c_addr(struct usb_device *usb_dev, > static int vprbrd_i2c_read(struct vprbrd *vb, struct i2c_msg *msg) > { > int ret; > - u16 remain_len, bytes_xfer, len1, len2, > - start = 0x0000; > + u16 remain_len, len1, len2, start = 0x0000; > struct vprbrd_i2c_read_msg *rmsg = > (struct vprbrd_i2c_read_msg *)vb->buf; > > @@ -166,7 +165,6 @@ static int vprbrd_i2c_read(struct vprbrd *vb, struct > i2c_msg *msg) rmsg->header.len3 = remain_len - 512; > rmsg->header.len4 = 0x00; > rmsg->header.len5 = 0x00; > - bytes_xfer = remain_len; > remain_len = 0; > } else if (remain_len <= 1022) { > len1 = 512; Acked-by: Lars Poeschel <poeschel@lemonage.de> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jan 04, 2014 at 10:21:33PM +0100, Wolfram Sang wrote: > cppcheck rightfully says: > > drivers/i2c/busses/i2c-viperboard.c:169: style: Variable 'bytes_xfer' is assigned a value that is never used. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c index 6976e1c..7533fa3 100644 --- a/drivers/i2c/busses/i2c-viperboard.c +++ b/drivers/i2c/busses/i2c-viperboard.c @@ -118,8 +118,7 @@ static int vprbrd_i2c_addr(struct usb_device *usb_dev, static int vprbrd_i2c_read(struct vprbrd *vb, struct i2c_msg *msg) { int ret; - u16 remain_len, bytes_xfer, len1, len2, - start = 0x0000; + u16 remain_len, len1, len2, start = 0x0000; struct vprbrd_i2c_read_msg *rmsg = (struct vprbrd_i2c_read_msg *)vb->buf; @@ -166,7 +165,6 @@ static int vprbrd_i2c_read(struct vprbrd *vb, struct i2c_msg *msg) rmsg->header.len3 = remain_len - 512; rmsg->header.len4 = 0x00; rmsg->header.len5 = 0x00; - bytes_xfer = remain_len; remain_len = 0; } else if (remain_len <= 1022) { len1 = 512;
cppcheck rightfully says: drivers/i2c/busses/i2c-viperboard.c:169: style: Variable 'bytes_xfer' is assigned a value that is never used. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/i2c/busses/i2c-viperboard.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)