diff mbox

[U-Boot,v2,1/6] wandboard: Return from cpu_eth_init() directly

Message ID 1388864193-5716-1-git-send-email-festevam@gmail.com
State Accepted
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Jan. 4, 2014, 7:36 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.

In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- None

 board/wandboard/wandboard.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

Comments

Stefano Babic Jan. 13, 2014, 10:56 a.m. UTC | #1 
On 04/01/2014 20:36, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to print an error message when cpu_eth_init() fails because
> net/eth.c already prints it.
> 
> In order to simplify the code, just return the value from cpu_eth_init(bis)
> directly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied (whole series) to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 0043bc6..72e9bb2 100644e
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -257,15 +257,9 @@  static void setup_display(void)
 
 int board_eth_init(bd_t *bis)
 {
-	int ret;
-
 	setup_iomux_enet();
 
-	ret = cpu_eth_init(bis);
-	if (ret)
-		printf("FEC MXC: %s:failed\n", __func__);
-
-	return ret;
+	return cpu_eth_init(bis);
 }
 
 int board_early_init_f(void)