Patchwork [v3,5/5] mtd: nand: use __packed shorthand

login
register
mail settings
Submitter Brian Norris
Date Jan. 4, 2014, 12:37 a.m.
Message ID <1388795828-24808-5-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/306758/
State New
Headers show

Comments

Brian Norris - Jan. 4, 2014, 12:37 a.m.
To be consistent with the rest of include/linux/mtd/nand.h, we should
use the __packed shorthand instead of __attribute__((packed)).

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
No change since v1

 include/linux/mtd/nand.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Huang Shijie - Jan. 7, 2014, 5:52 a.m.
On Fri, Jan 03, 2014 at 04:37:08PM -0800, Brian Norris wrote:
> To be consistent with the rest of include/linux/mtd/nand.h, we should
> use the __packed shorthand instead of __attribute__((packed)).
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> No change since v1
> 
>  include/linux/mtd/nand.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index e3621aba1417..2413bac095ae 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -292,7 +292,7 @@ struct nand_onfi_params {
>  	u8 vendor[88];
>  
>  	__le16 crc;
> -} __attribute__((packed));
> +} __packed;
>  
>  #define ONFI_CRC_BASE	0x4F4E
>  
> -- 
> 1.8.3.2
> 
> 
> 
Acked-by: Huang Shijie <b32955@freescale.com>

Patch

diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index e3621aba1417..2413bac095ae 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -292,7 +292,7 @@  struct nand_onfi_params {
 	u8 vendor[88];
 
 	__le16 crc;
-} __attribute__((packed));
+} __packed;
 
 #define ONFI_CRC_BASE	0x4F4E