From patchwork Fri Jan 3 19:48:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 306671 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5C0872C00A8 for ; Sat, 4 Jan 2014 06:48:42 +1100 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VzAjR-0007mZ-HU; Fri, 03 Jan 2014 19:48:33 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VzAjP-0006oB-Si; Fri, 03 Jan 2014 19:48:31 +0000 Received: from mail-oa0-f43.google.com ([209.85.219.43]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VzAjN-0006nX-UN for linux-mtd@lists.infradead.org; Fri, 03 Jan 2014 19:48:30 +0000 Received: by mail-oa0-f43.google.com with SMTP id i7so16549838oag.16 for ; Fri, 03 Jan 2014 11:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=H1OTLTUm3dTqY/sivVWFTYTDmT8Z2NlCQYTsW4PwFaQ=; b=kUueDp/CjUwPQpYhSh9FmpsrOFlnViFshYjWoyHbcqTLtzanLDs4tckQL6THZ9urLz ABNofxEh+jN7LeNwAyzD+0GLTzzvWl+997tsBjP/M7dPpxx3FjEIYpxZC4qs85jrN9+q 7vcLjLl8vK6LmGmAoVJX1N6FqmTjkOJ/bqPMNET0OEK+z6OEa3pPntQlyPKZkU1XwffD pT3qWhTYVeQTUvCvVHRRtgDgHKDjBIdtEzXCsm2Z+t6EK0G4xVdEUuitdYQGXGRHfwW1 HGHIYQs8f3e2Xeb3cELcX6SCXlAWpwcdSsySlmfZ7GBzTCJAUsZb2Y6XmBu3ZWQyIMtG eRAA== X-Received: by 10.182.28.35 with SMTP id y3mr2391344obg.55.1388778485184; Fri, 03 Jan 2014 11:48:05 -0800 (PST) Received: from ld-irv-0074 (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id si9sm85803030oeb.8.2014.01.03.11.48.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 03 Jan 2014 11:48:04 -0800 (PST) Date: Fri, 3 Jan 2014 11:48:01 -0800 From: Brian Norris To: Ezequiel Garcia Subject: Re: [RFC/PATCH] mtd: Hide CONFIG_MTD_BLKDEVS from the menu Message-ID: <20140103194801.GN5631@ld-irv-0074> References: <1386943124-8005-1-git-send-email-ezequiel.garcia@free-electrons.com> <20131220004712.GA12803@localhost> <20131220020518.GB18175@norris-Latitude-E6410> <20131220181757.GA17786@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131220181757.GA17786@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140103_144830_021827_6C04DEC7 X-CRM114-Status: GOOD ( 15.90 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.219.43 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-mtd@lists.infradead.org, David Woodhouse , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Fri, Dec 20, 2013 at 03:17:58PM -0300, Ezequiel Garcia wrote: > On Thu, Dec 19, 2013 at 06:05:18PM -0800, Brian Norris wrote: > > On Thu, Dec 19, 2013 at 09:47:13PM -0300, Ezequiel Garcia wrote: > > > Any comments on this one? > > > > It looks OK to me. I might add a comment above MTD_BLKDEVS like I see in > > some other similar Kconfig not-user-selectable options: > > > > # > > # MTD block device support is select'ed if needed > > # > > > > Fully agreed. Since I didn't receive a follow-up, I just added the comment and pushed to l2-mtd.git. Diff pasted below. Thanks, Brian diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 5fab4e6e8301..cdaa4e512c97 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -157,10 +157,11 @@ config MTD_BCM47XX_PARTS comment "User Modules And Translation Layers" +# +# MTD block device support is select'ed if needed +# config MTD_BLKDEVS - tristate "Common interface to block layer for MTD 'translation layers'" - depends on BLOCK - default n + bool config MTD_BLOCK tristate "Caching block device access to MTD devices"