Patchwork [RFC/PATCH] mtd: Hide CONFIG_MTD_BLKDEVS from the menu

login
register
mail settings
Submitter Brian Norris
Date Jan. 3, 2014, 7:48 p.m.
Message ID <20140103194801.GN5631@ld-irv-0074>
Download mbox | patch
Permalink /patch/306671/
State New
Headers show

Comments

Brian Norris - Jan. 3, 2014, 7:48 p.m.
On Fri, Dec 20, 2013 at 03:17:58PM -0300, Ezequiel Garcia wrote:
> On Thu, Dec 19, 2013 at 06:05:18PM -0800, Brian Norris wrote:
> > On Thu, Dec 19, 2013 at 09:47:13PM -0300, Ezequiel Garcia wrote:
> > > Any comments on this one?
> > 
> > It looks OK to me. I might add a comment above MTD_BLKDEVS like I see in
> > some other similar Kconfig not-user-selectable options:
> > 
> > #
> > # MTD block device support is select'ed if needed
> > #
> > 
> 
> Fully agreed.

Since I didn't receive a follow-up, I just added the comment and pushed
to l2-mtd.git. Diff pasted below.

Thanks,
Brian

Patch

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 5fab4e6e8301..cdaa4e512c97 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -157,10 +157,11 @@  config MTD_BCM47XX_PARTS
 
 comment "User Modules And Translation Layers"
 
+#
+# MTD block device support is select'ed if needed
+#
 config MTD_BLKDEVS
-	tristate "Common interface to block layer for MTD 'translation layers'"
-	depends on BLOCK
-	default n
+	bool
 
 config MTD_BLOCK
 	tristate "Caching block device access to MTD devices"