From patchwork Fri Jan 3 09:53:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Kim_B=C3=B8ndergaard_Poulsen?= X-Patchwork-Id: 306520 X-Patchwork-Delegate: esben@haabendal.dk Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hugin.dotsrc.org (hugin.dotsrc.org [IPv6:2001:878:346::102]) by ozlabs.org (Postfix) with ESMTP id 8E6412C0084 for ; Fri, 3 Jan 2014 20:53:26 +1100 (EST) Received: from hugin.dotsrc.org (localhost [127.0.0.1]) by hugin.dotsrc.org (Postfix) with ESMTP id 1FCC93FF54 for ; Fri, 3 Jan 2014 10:53:24 +0100 (CET) X-Original-To: dev@oe-lite.org Delivered-To: dev@oe-lite.org Received: from mail02.prevas.se (mail02.prevas.se [62.95.78.10]) by hugin.dotsrc.org (Postfix) with ESMTPS id 9280A3FF54 for ; Fri, 3 Jan 2014 10:53:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=prevas.dk; i=@prevas.dk; l=4350; q=dns/txt; s=ironport2; t=1388742802; x=1420278802; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=vXEW8e+SgYtwbLxJ1zUpCn6EFCfBLfMQGrrmlykp2BQ=; b=wfIHcD/OtvbJV6n6WJsSa8cvfwQ1gvImRZvV7o/cA0ewt/wcx/mNkJ0B x04Knc4Bz0ee8FLoE9PgjtfeDteqIhVbxuFDpOyq/0HwIj6t8DLbkKRFW egVN7mTiPROHM7x50u2Z/o67EhI3B4i+JZ8TwmSZQ6WpWkjyAomq6St+9 I=; X-IronPort-AV: E=Sophos;i="4.95,596,1384297200"; d="scan'208";a="167567" Received: from vmprevas4.prevas.se (HELO smtp.prevas.se) ([172.16.8.104]) by ironport2.prevas.se with ESMTP/TLS/AES128-SHA; 03 Jan 2014 10:53:21 +0100 Received: from VMPREVAS2.prevas.se ([fe80::ddc4:1ca4:65e1:d098]) by VMPREVAS4.prevas.se ([172.16.8.104]) with mapi id 14.02.0347.000; Fri, 3 Jan 2014 10:53:21 +0100 From: =?iso-8859-1?Q?Kim_B=F8ndergaard_Poulsen?= To: =?iso-8859-1?Q?Christian_Br=E4uner_S=F8rensen?= , "dev@oe-lite.org" Subject: RE: [PATCH 4/5] package-qa: Ensure '_' is replaced by '-' Thread-Topic: [PATCH 4/5] package-qa: Ensure '_' is replaced by '-' Thread-Index: AQHPCGBJfAey9oNHK0q4KzDSYx83TppyvuBn Date: Fri, 3 Jan 2014 09:53:20 +0000 Message-ID: <4014368E77617E44944113A4A656BD684605479D@VMPREVAS2.prevas.se> References: , In-Reply-To: Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.11.4] MIME-Version: 1.0 X-BeenThere: dev@oe-lite.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: OE-lite development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dev-bounces@oe-lite.org Errors-To: dev-bounces@oe-lite.org I think there is minor issue. Not that it destroys anything though. Just doing the same stuff more times. It relates to the change in line 620 which isn't required at all due to the change in line 483. Line 483 ensure _/- conversion always happen when sonamify() is called. Line 620 try do the same once more. diff --git a/classes/package-qa.oeclass b/classes/package-qa.oeclass index 4c6b8f2..25a9ef7 100644 --- a/classes/package-qa.oeclass +++ b/classes/package-qa.oeclass @@ -483,6 +483,7 @@ def do_packageqa(d): sonamify_re2 = re.compile(r"(.*?)(-[\d\.]*)?$") def sonamify(soname): def _sonamify(s): + s = s.replace("_","-") Kim: This change ensure conversion always happen when sonamify is called. m = sonamify_re.match(s)