diff mbox

[2/5] dupdate-image: if fwupdate is present, copy it into the image

Message ID 8d46a4b20f489818fe2dbfa38e554243a2b641ff.1388738733.git.christian.braunersorensen@prevas.dk
State Changes Requested
Delegated to: Esben Haabendal
Headers show

Commit Message

christian.braunersorensen@prevas.dk Jan. 3, 2014, 8:46 a.m. UTC 
From: Christian Sørensen <christian.braunersorensen@prevas.dk>

---
 classes/dupdate-image.oeclass | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Esben Haabendal Jan. 3, 2014, 10:40 a.m. UTC | #1 
<christian.braunersorensen@prevas.dk> writes:

> From: Christian Sørensen <christian.braunersorensen@prevas.dk>
>
> ---
>  classes/dupdate-image.oeclass | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/classes/dupdate-image.oeclass b/classes/dupdate-image.oeclass
> index f8af6a2..3f94b0b 100644
> --- a/classes/dupdate-image.oeclass
> +++ b/classes/dupdate-image.oeclass
> @@ -63,6 +63,13 @@ do_rstage_dupdate_script () {
>  }
>  do_rstage_dupdate_script[dirs] = "${RSTAGE_DIR}"
>  
> +do_rstage[postfuncs] += "do_rstage_fwupdate"
> +do_rstage_fwupdate () {
> +    if [ -f ${SRCDIR}/fwupdate ]; then
> +        cp ${SRCDIR}/fwupdate ${RSTAGE_DIR}
> +    fi
> +}
> +
>  do_deploy[postfuncs] += "do_deploy_dupdate_image"
>  do_deploy_dupdate_image () {
>  	install -m 664 ${B}/${IMAGE_BASENAME}${DUPDATE_IMAGE_EXT} \

This looks like something that relates to a specific dupdate script, and
not a generic feature of dupdate image.

Perhaps you can change it to instead provide a USE flag for providing (a
list of) additional files, which needs to be merged with rstage.

Also, please add the function to IMAGE_PREPROCESS_FUNCS and mangle
IMAGE_DIR instead of RSTAGE_DIR which should normally not be messed
around with.

The current do_rstage_dupdate_script function should probably be changed
to an IMAGE_PREPROCESS_FUNCS also...

/Esben
diff mbox

Patch

diff --git a/classes/dupdate-image.oeclass b/classes/dupdate-image.oeclass
index f8af6a2..3f94b0b 100644
--- a/classes/dupdate-image.oeclass
+++ b/classes/dupdate-image.oeclass
@@ -63,6 +63,13 @@  do_rstage_dupdate_script () {
 }
 do_rstage_dupdate_script[dirs] = "${RSTAGE_DIR}"
 
+do_rstage[postfuncs] += "do_rstage_fwupdate"
+do_rstage_fwupdate () {
+    if [ -f ${SRCDIR}/fwupdate ]; then
+        cp ${SRCDIR}/fwupdate ${RSTAGE_DIR}
+    fi
+}
+
 do_deploy[postfuncs] += "do_deploy_dupdate_image"
 do_deploy_dupdate_image () {
 	install -m 664 ${B}/${IMAGE_BASENAME}${DUPDATE_IMAGE_EXT} \