diff mbox

[U-Boot,2/2] net: phy: atheros: Fix the masks for AR8031/8035

Message ID 1388684557-12121-2-git-send-email-festevam@gmail.com
State Accepted
Delegated to: Joe Hershberger
Headers show

Commit Message

Fabio Estevam Jan. 2, 2014, 5:42 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Use the same masks as used in the kernel:
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/net/phy/at803x.c?id=refs/tags/v3.12.6

With such changes Ethernet is functional on hummingboard solo. 

Cc: Joe Hershberger <joe.hershberger@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/net/phy/atheros.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Babic Jan. 3, 2014, 10:05 a.m. UTC | #1 
On 02/01/2014 18:42, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Use the same masks as used in the kernel:
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/net/phy/at803x.c?id=refs/tags/v3.12.6
> 
> With such changes Ethernet is functional on hummingboard solo. 
> 
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/net/phy/atheros.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
> index 0f2dfd6..386e3ab 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -50,7 +50,7 @@ static struct phy_driver AR8021_driver =  {
>  static struct phy_driver AR8031_driver =  {
>  	.name = "AR8031",
>  	.uid = 0x4dd074,
> -	.mask = 0xfffff0,
> +	.mask = 0xffffffef,
>  	.features = PHY_GBIT_FEATURES,
>  	.config = genphy_config,
>  	.startup = genphy_startup,
> @@ -60,7 +60,7 @@ static struct phy_driver AR8031_driver =  {
>  static struct phy_driver AR8035_driver =  {
>  	.name = "AR8035",
>  	.uid = 0x4dd072,
> -	.mask = 0x4fffff,
> +	.mask = 0xffffffef,
>  	.features = PHY_GBIT_FEATURES,
>  	.config = ar8035_config,
>  	.startup = genphy_startup,
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
index 0f2dfd6..386e3ab 100644
--- a/drivers/net/phy/atheros.c
+++ b/drivers/net/phy/atheros.c
@@ -50,7 +50,7 @@  static struct phy_driver AR8021_driver =  {
 static struct phy_driver AR8031_driver =  {
 	.name = "AR8031",
 	.uid = 0x4dd074,
-	.mask = 0xfffff0,
+	.mask = 0xffffffef,
 	.features = PHY_GBIT_FEATURES,
 	.config = genphy_config,
 	.startup = genphy_startup,
@@ -60,7 +60,7 @@  static struct phy_driver AR8031_driver =  {
 static struct phy_driver AR8035_driver =  {
 	.name = "AR8035",
 	.uid = 0x4dd072,
-	.mask = 0x4fffff,
+	.mask = 0xffffffef,
 	.features = PHY_GBIT_FEATURES,
 	.config = ar8035_config,
 	.startup = genphy_startup,