diff mbox

[buildrobot] Fix redefinition of BITS_PER_UNIT (was: nios2 port committed)

Message ID 20131231202621.GE4803@lug-owl.de
State New
Headers show

Commit Message

Jan-Benedict Glaw Dec. 31, 2013, 8:26 p.m. UTC
On Tue, 2013-12-31 15:24:52 +0800, Chung-Lin Tang <cltang@codesourcery.com> wrote:
> The nios2 port was just committed. Thanks to all that gave time and
> effort to review this.

Just a heads-up: I see a lot of warnings about BITS_PER_UNIT being
redefined, see eg.
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=74923
as an example.


2013-12-31  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

	* config/nios2/nios2.h (BITS_PER_UNIT): Don't define it.




Ok?

MfG, JBG

Comments

Mike Stump Jan. 1, 2014, 6:45 a.m. UTC | #1
On Dec 31, 2013, at 12:26 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Tue, 2013-12-31 15:24:52 +0800, Chung-Lin Tang <cltang@codesourcery.com> wrote:
>> The nios2 port was just committed. Thanks to all that gave time and
>> effort to review this.
> 
> Just a heads-up: I see a lot of warnings about BITS_PER_UNIT being
> redefined, see eg.
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=74923
> as an example.
> 
> 
> 2013-12-31  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> 
> 	* config/nios2/nios2.h (BITS_PER_UNIT): Don't define it.
> 
> diff --git a/gcc/config/nios2/nios2.h b/gcc/config/nios2/nios2.h
> index 8e6941b..f333be3 100644
> --- a/gcc/config/nios2/nios2.h
> +++ b/gcc/config/nios2/nios2.h
> @@ -73,7 +73,6 @@
> #define BITS_BIG_ENDIAN 0
> #define BYTES_BIG_ENDIAN (TARGET_BIG_ENDIAN != 0)
> #define WORDS_BIG_ENDIAN (TARGET_BIG_ENDIAN != 0)
> -#define BITS_PER_UNIT 8
> #define BITS_PER_WORD 32
> #define UNITS_PER_WORD 4
> #define POINTER_SIZE 32
> 
> 
> Ok?

Ok.
Chung-Lin Tang Jan. 1, 2014, 10:03 a.m. UTC | #2
On 2014/1/1 02:45 PM, Mike Stump wrote:
> On Dec 31, 2013, at 12:26 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> On Tue, 2013-12-31 15:24:52 +0800, Chung-Lin Tang <cltang@codesourcery.com> wrote:
>>> The nios2 port was just committed. Thanks to all that gave time and
>>> effort to review this.
>>
>> Just a heads-up: I see a lot of warnings about BITS_PER_UNIT being
>> redefined, see eg.
>> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=74923
>> as an example.
>>
>>
>> 2013-12-31  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
>>
>> 	* config/nios2/nios2.h (BITS_PER_UNIT): Don't define it.
>>
>> diff --git a/gcc/config/nios2/nios2.h b/gcc/config/nios2/nios2.h
>> index 8e6941b..f333be3 100644
>> --- a/gcc/config/nios2/nios2.h
>> +++ b/gcc/config/nios2/nios2.h
>> @@ -73,7 +73,6 @@
>> #define BITS_BIG_ENDIAN 0
>> #define BYTES_BIG_ENDIAN (TARGET_BIG_ENDIAN != 0)
>> #define WORDS_BIG_ENDIAN (TARGET_BIG_ENDIAN != 0)
>> -#define BITS_PER_UNIT 8
>> #define BITS_PER_WORD 32
>> #define UNITS_PER_WORD 4
>> #define POINTER_SIZE 32
>>
>>
>> Ok?
> 
> Ok.
> 

Thanks for catching that.
diff mbox

Patch

diff --git a/gcc/config/nios2/nios2.h b/gcc/config/nios2/nios2.h
index 8e6941b..f333be3 100644
--- a/gcc/config/nios2/nios2.h
+++ b/gcc/config/nios2/nios2.h
@@ -73,7 +73,6 @@ 
 #define BITS_BIG_ENDIAN 0
 #define BYTES_BIG_ENDIAN (TARGET_BIG_ENDIAN != 0)
 #define WORDS_BIG_ENDIAN (TARGET_BIG_ENDIAN != 0)
-#define BITS_PER_UNIT 8
 #define BITS_PER_WORD 32
 #define UNITS_PER_WORD 4
 #define POINTER_SIZE 32