diff mbox

package: libpng: don't append prefix to symbol names in the version script file

Message ID 1388399753-11513-1-git-send-email-Sonic.adi@gmail.com
State Accepted
Headers show

Commit Message

Sonic Zhang Dec. 30, 2013, 10:35 a.m. UTC
From: Sonic Zhang <sonic.zhang@analog.com>

Even if Blackfin GNU toolchain add prefix '_' to all symbols,
symbol prefix is not accepted in the link flag --version-script.
Don't append prefix in the symbols in the version script file.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
 .../libpng/libpng-02-ingore-symbol-prefix.patch    |   26 ++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch

Comments

Sonic Zhang Jan. 6, 2014, 2:14 a.m. UTC | #1
Ping

Sonic Zhang

On Mon, Dec 30, 2013 at 6:35 PM,  <sonic.adi@gmail.com> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Even if Blackfin GNU toolchain add prefix '_' to all symbols,
> symbol prefix is not accepted in the link flag --version-script.
> Don't append prefix in the symbols in the version script file.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
>  .../libpng/libpng-02-ingore-symbol-prefix.patch    |   26 ++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
>
> diff --git a/package/libpng/libpng-02-ingore-symbol-prefix.patch b/package/libpng/libpng-02-ingore-symbol-prefix.patch
> new file mode 100644
> index 0000000..7f2cfff
> --- /dev/null
> +++ b/package/libpng/libpng-02-ingore-symbol-prefix.patch
> @@ -0,0 +1,26 @@
> +Even if Blackfin GNU toolchain add prefix '_' to all symbols,
> +symbol prefix is not accepted in the link flag --version-script.
> +Don't append prefix in the symbols in the version script file.
> +
> +--- libpng-1.6.8/Makefile.am   2013-12-30 18:23:08.261797417 +0800
> ++++ libpng-1.6.8.bak/Makefile.am       2013-12-30 18:22:15.565795726 +0800
> +@@ -225,7 +225,7 @@
> + # interfering with the symbol file format.
> + SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG@PNGLIB_MAJOR@@PNGLIB_MINOR@_0'\
> +               -DPNGLIB_VERSION='@PNGLIB_VERSION@'\
> +-              -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)'\
> ++              -DSYMBOL_PREFIX=''\
> +               -DPNG_NO_USE_READ_MACROS -DPNG_BUILDING_SYMBOL_TABLE
> +
> + if DO_PNG_PREFIX
> +--- libpng-1.6.8/Makefile.in   2013-12-30 18:23:08.261797417 +0800
> ++++ libpng-1.6.8.bak/Makefile.in       2013-12-30 18:22:09.853794547 +0800
> +@@ -698,7 +698,7 @@
> + # interfering with the symbol file format.
> + SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG@PNGLIB_MAJOR@@PNGLIB_MINOR@_0' \
> +       -DPNGLIB_VERSION='@PNGLIB_VERSION@' \
> +-      -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \
> ++      -DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \
> +       -DPNG_BUILDING_SYMBOL_TABLE $(am__append_5)
> + all: $(BUILT_SOURCES) config.h
> +       $(MAKE) $(AM_MAKEFLAGS) all-am
> --
> 1.7.9.5
>
Peter Korsgaard Jan. 14, 2014, 10:01 p.m. UTC | #2
>>>>> "sonic" == sonic adi <sonic.adi@gmail.com> writes:

 > From: Sonic Zhang <sonic.zhang@analog.com>
 > Even if Blackfin GNU toolchain add prefix '_' to all symbols,
 > symbol prefix is not accepted in the link flag --version-script.
 > Don't append prefix in the symbols in the version script file.

 > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
 > ---
 >  .../libpng/libpng-02-ingore-symbol-prefix.patch    |   26 ++++++++++++++++++++
 >  1 file changed, 26 insertions(+)
 >  create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch

 > diff --git a/package/libpng/libpng-02-ingore-symbol-prefix.patch b/package/libpng/libpng-02-ingore-symbol-prefix.patch
 > new file mode 100644
 > index 0000000..7f2cfff
 > --- /dev/null
 > +++ b/package/libpng/libpng-02-ingore-symbol-prefix.patch

Committed with the filename typo fixed, thanks.
diff mbox

Patch

diff --git a/package/libpng/libpng-02-ingore-symbol-prefix.patch b/package/libpng/libpng-02-ingore-symbol-prefix.patch
new file mode 100644
index 0000000..7f2cfff
--- /dev/null
+++ b/package/libpng/libpng-02-ingore-symbol-prefix.patch
@@ -0,0 +1,26 @@ 
+Even if Blackfin GNU toolchain add prefix '_' to all symbols,
+symbol prefix is not accepted in the link flag --version-script.
+Don't append prefix in the symbols in the version script file.
+
+--- libpng-1.6.8/Makefile.am	2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.am	2013-12-30 18:22:15.565795726 +0800
+@@ -225,7 +225,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG@PNGLIB_MAJOR@@PNGLIB_MINOR@_0'\
+ 		-DPNGLIB_VERSION='@PNGLIB_VERSION@'\
+-		-DSYMBOL_PREFIX='$(SYMBOL_PREFIX)'\
++		-DSYMBOL_PREFIX=''\
+ 		-DPNG_NO_USE_READ_MACROS -DPNG_BUILDING_SYMBOL_TABLE
+ 
+ if DO_PNG_PREFIX
+--- libpng-1.6.8/Makefile.in	2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.in	2013-12-30 18:22:09.853794547 +0800
+@@ -698,7 +698,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG@PNGLIB_MAJOR@@PNGLIB_MINOR@_0' \
+ 	-DPNGLIB_VERSION='@PNGLIB_VERSION@' \
+-	-DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \
++	-DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \
+ 	-DPNG_BUILDING_SYMBOL_TABLE $(am__append_5)
+ all: $(BUILT_SOURCES) config.h
+ 	$(MAKE) $(AM_MAKEFLAGS) all-am