Message ID | 20131226100905.00ac74a2@nehalam.linuxnetplumber.net |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Stephen Hemminger <stephen@networkplumber.org> Date: Thu, 26 Dec 2013 10:09:05 -0800 > This module shouldn't be randomly exporting symbols > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/sched/sch_hhf.c 2013-12-24 15:14:54.398175948 -0800 +++ b/net/sched/sch_hhf.c 2013-12-24 15:16:02.409262185 -0800 @@ -711,7 +711,7 @@ static int hhf_dump_stats(struct Qdisc * return gnet_stats_copy_app(d, &st, sizeof(st)); } -struct Qdisc_ops hhf_qdisc_ops __read_mostly = { +static struct Qdisc_ops hhf_qdisc_ops __read_mostly = { .id = "hhf", .priv_size = sizeof(struct hhf_sched_data), @@ -727,7 +727,6 @@ struct Qdisc_ops hhf_qdisc_ops __read_mo .dump_stats = hhf_dump_stats, .owner = THIS_MODULE, }; -EXPORT_SYMBOL(hhf_qdisc_ops); static int __init hhf_module_init(void) {
This module shouldn't be randomly exporting symbols Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- net/sched/sch_hhf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html