Message ID | 1388060390-16447-2-git-send-email-marcel.a@redhat.com |
---|---|
State | New |
Headers | show |
On Thu, Dec 26, 2013 at 02:19:49PM +0200, Marcel Apfelbaum wrote: > Acpi unit-test will fail every time the acpi tables change. > This script rebuild the expected aml files, so the test > will pass. It also validates the modifications. > > Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com> > --- > v1 -> v2: > Addressed Michael S. Tsirkin's comments: > - added TEST_ prefix to the environment variable > - some rephrases > > tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh > > diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh > new file mode 100755 > index 0000000..6753469 > --- /dev/null > +++ b/tests/acpi-test-data/rebuild-expected-aml.sh > @@ -0,0 +1,36 @@ > +#! /bin/bash > + > +# > +# Rebuild expected AML files for acpi unit-test trailing space here > +# > +# Copyright (c) 2013 Red Hat Inc. > +# > +# Authors: > +# Marcel Apfelbaum <marcel.a@redhat.com> > +# > +# This work is licensed under the terms of the GNU GPLv2. > +# See the COPYING.LIB file in the top-level directory. > + > +qemu= > + > +if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then > + qemu="x86_64-softmmu/qemu-system-x86_64" > +elif [ -e i386-softmmu/qemu-system-i386 ]; then > + qemu="i386-softmmu/qemu-system-i386" > +else > + echo "Run 'make' to build the qemu exectutable!" > + echo "Run this script from the build directory." > + exit 1; > +fi > + > +if [ ! -e "tests/acpi-test" ]; then > + echo "Test: acpi-test is required! Run make check before this script." > + echo "Run this script from the build directory." > + exit 1; > +fi > + > +TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test > + > +echo "The files were rebuilt and can be added to git." > +echo "However, if new files were created, please copy them manually" \ > + "to tests/acpi-test-data/pc/ or tests/acpi-test-data/q35/ ." > -- > 1.8.3.1
diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh new file mode 100755 index 0000000..6753469 --- /dev/null +++ b/tests/acpi-test-data/rebuild-expected-aml.sh @@ -0,0 +1,36 @@ +#! /bin/bash + +# +# Rebuild expected AML files for acpi unit-test +# +# Copyright (c) 2013 Red Hat Inc. +# +# Authors: +# Marcel Apfelbaum <marcel.a@redhat.com> +# +# This work is licensed under the terms of the GNU GPLv2. +# See the COPYING.LIB file in the top-level directory. + +qemu= + +if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then + qemu="x86_64-softmmu/qemu-system-x86_64" +elif [ -e i386-softmmu/qemu-system-i386 ]; then + qemu="i386-softmmu/qemu-system-i386" +else + echo "Run 'make' to build the qemu exectutable!" + echo "Run this script from the build directory." + exit 1; +fi + +if [ ! -e "tests/acpi-test" ]; then + echo "Test: acpi-test is required! Run make check before this script." + echo "Run this script from the build directory." + exit 1; +fi + +TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test + +echo "The files were rebuilt and can be added to git." +echo "However, if new files were created, please copy them manually" \ + "to tests/acpi-test-data/pc/ or tests/acpi-test-data/q35/ ."
Acpi unit-test will fail every time the acpi tables change. This script rebuild the expected aml files, so the test will pass. It also validates the modifications. Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com> --- v1 -> v2: Addressed Michael S. Tsirkin's comments: - added TEST_ prefix to the environment variable - some rephrases tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh