From patchwork Thu Dec 26 03:32:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 305188 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 73DF42C0095 for ; Thu, 26 Dec 2013 14:33:06 +1100 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1gz-0002ab-AY; Thu, 26 Dec 2013 03:33:01 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1gx-0003sl-KW; Thu, 26 Dec 2013 03:32:59 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1gv-0003rU-5X for linux-mtd@lists.infradead.org; Thu, 26 Dec 2013 03:32:58 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MYE003IE9U7J840@mailout3.samsung.com> for linux-mtd@lists.infradead.org; Thu, 26 Dec 2013 12:32:31 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id DE.90.09028.E43ABB25; Thu, 26 Dec 2013 12:32:30 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-75-52bba34ebd20 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id CD.0D.29263.E43ABB25; Thu, 26 Dec 2013 12:32:30 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MYE00LZR9U5Q070@mmp2.samsung.com>; Thu, 26 Dec 2013 12:32:29 +0900 (KST) From: Jingoo Han To: 'Brian Norris' References: <009b01cf01ea$bac213d0$30463b70$%han@samsung.com> In-reply-to: <009b01cf01ea$bac213d0$30463b70$%han@samsung.com> Subject: [PATCH V2 4/4] mtd: sharpsl: use dev_err() instead of printk() Date: Thu, 26 Dec 2013 12:32:29 +0900 Message-id: <009f01cf01eb$1af59c40$50e0d4c0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8B6rqodrmeNeieRzqk0s/NfP1GzgAAErmQ Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t8zA12/xbuDDBZNFLI4cmEts8XElZOZ LS4vvMRqsbtpGbsDi8fOWXfZPTav0PLYvKTeo2/LKsYAligum5TUnMyy1CJ9uwSujN3bvrIU HGOrWP9rGlsD43rWLkZODgkBE4n1fT1QtpjEhXvr2boYuTiEBJYxSvyYd4Qdpmjp9a/sEInp jBJX335mhXB+MUo0r3vKCFLFJqAm8eXLYaAqDg4RAQOJH28yQcLMAgUSLW2vwAYJCdhKzN16 hQ3E5hSwk5j/dA6YLSzgLjH5zA8mEJtFQFXi7ZnfYPW8QPWbmnYwQtiCEj8m32OBmKklsX7n cSYIW15i85q3zCBrJQTUJR791QUJiwgYSZw42QhVLiKx78U7RpCTJQROsUs8Wn0VapeAxLfJ h1ggemUlNh1ghvhXUuLgihssExglZiHZPAvJ5llINs9CsmIBI8sqRtHUguSC4qT0IiO94sTc 4tK8dL3k/NxNjJCY7NvBePOA9SHGZKD1E5mlRJPzgTGdVxJvaGxmZGFqYmpsZG5pRpqwkjjv oodJQUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYw93WidVcbUnkyg41tlrEfdfv3Im0JXWr X+9V+Jd5oISryGRBieJbzjMGCkfXbWb/wrdcYcqH+Zc8Z9hlL8/h50wzN66IW7Po3qzliRbP znw5ULBo7pU3pc1zbyy7Ivn9htzC9qWWiTMFfs6+Y/a6nj/S6eXb/btDMg0WN/8917NM4wv/ +7kfHyixFGckGmoxFxUnAgAQTR7c3wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jQV2/xbuDDLa+5rM4cmEts8XElZOZ LS4vvMRqsbtpGbsDi8fOWXfZPTav0PLYvKTeo2/LKsYAlqgGRpuM1MSU1CKF1Lzk/JTMvHRb Je/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoJVKCmWJOaVAoYDE4mIlfTtME0JD3HQt YBojdH1DguB6jAzQQMI6xozd276yFBxjq1j/axpbA+N61i5GTg4JAROJpde/skPYYhIX7q1n 62Lk4hASmM4ocfXtZ1YI5xejRPO6p4wgVWwCahJfvhwG6uDgEBEwkPjxJhMkzCxQINHS9gps kJCArcTcrVfYQGxOATuJ+U/ngNnCAu4Sk8/8YAKxWQRUJd6e+Q1WzwtUv6lpByOELSjxY/I9 FoiZWhLrdx5ngrDlJTavecsMslZCQF3i0V9dkLCIgJHEiZONUOUiEvtevGOcwCg0C8mkWUgm zUIyaRaSlgWMLKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgiP+mdQOxpUNFocYBTgYlXh4 O3R3BwmxJpYVV+YeYpTgYFYS4d3VDRTiTUmsrEotyo8vKs1JLT7EmAz06ERmKdHkfGAyyiuJ NzQ2MTOyNDKzMDIxNydNWEmc90CrdaCQQHpiSWp2ampBahHMFiYOTqkGxhhhXfnlwueOGX5e 5sfM1hD26Zzc8gm1q9m1wwK1Pq/T8P8q9dopnEP2c1yJp6qPck7pB/ZXIUbJCZaPIwRTFthf On/e/KG80Mwbaxln8ZhNZvP0na/XIqCVW6v0smDlkU0HJGzi7aasnqV9aJ56jmTO7Ki8NO+N nYn7xAOf9dxvZ/wiI/VRiaU4I9FQi7moOBEA1AISYTwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131225_223257_466168_58162D6F X-CRM114-Status: UNSURE ( 8.37 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.5 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.33 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-mtd@lists.infradead.org, 'Jingoo Han' , 'David Woodhouse' X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Use dev_err() instead of printk() to provide a better message to userspace. Signed-off-by: Jingoo Han --- Change since v1 - Remove the site-specific OOM messages. drivers/mtd/nand/sharpsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c index 61a85ab..e81059b 100644 --- a/drivers/mtd/nand/sharpsl.c +++ b/drivers/mtd/nand/sharpsl.c @@ -134,7 +134,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev) /* map physical address */ sharpsl->io = ioremap(r->start, resource_size(r)); if (!sharpsl->io) { - printk("ioremap to access Sharp SL NAND chip failed\n"); + dev_err(&pdev->dev, "ioremap to access Sharp SL NAND chip failed\n"); err = -EIO; goto err_ioremap; }