From patchwork Thu Dec 26 03:30:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 305185 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 29D7E2C0098 for ; Thu, 26 Dec 2013 14:31:32 +1100 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1fS-0001o5-MQ; Thu, 26 Dec 2013 03:31:26 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1fR-0003nD-1h; Thu, 26 Dec 2013 03:31:25 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vw1fM-0003m5-OA for linux-mtd@lists.infradead.org; Thu, 26 Dec 2013 03:31:22 +0000 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MYE0086P9RM3X40@mailout1.samsung.com> for linux-mtd@lists.infradead.org; Thu, 26 Dec 2013 12:30:58 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id AF.26.10364.2F2ABB25; Thu, 26 Dec 2013 12:30:58 +0900 (KST) X-AuditID: cbfee690-b7f266d00000287c-29-52bba2f23394 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 0D.CC.29263.2F2ABB25; Thu, 26 Dec 2013 12:30:58 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MYE008JM9RMNP10@mmp1.samsung.com>; Thu, 26 Dec 2013 12:30:58 +0900 (KST) From: Jingoo Han To: 'Brian Norris' References: <009b01cf01ea$bac213d0$30463b70$%han@samsung.com> In-reply-to: <009b01cf01ea$bac213d0$30463b70$%han@samsung.com> Subject: [PATCH V2 1/4] mtd: atmel_nand: use dev_err() instead of printk() Date: Thu, 26 Dec 2013 12:30:58 +0900 Message-id: <009c01cf01ea$e48f10f0$adad32d0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8B6rqodrmeNeieRzqk0s/NfP1GzgAAA92A Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t8zI91Pi3YHGezdbmhx5MJaZouXhzQt Jq6czGxxeeElVotdjb9ZLXY3LWN3YPNY8Gsri8fOWXfZPTav0PLYvKTeo2/LKsYA1igum5TU nMyy1CJ9uwSujItLBAt+slfM3/OdtYFxD1sXIyeHhICJxNOV+5khbDGJC/fWA8W5OIQEljFK tKyZxg5T9PrJAmaIxCJGief9axghnF+MEq07+sFGsQmoSXz5chiog4NDRMBA4sebTJAaZoF+ Ron9/ReZQGqEBGwl5m69AlbPKWAnMf/pHDBbWMBLYt+T82DbWARUJc4sbWIBsXmB6q+dW8EE YQtK/Jh8DyzOLKAlsX7ncSYIW15i85q3zCB7JQTUJR791YU4wUhi4WphiAoRiX0v3oGdLCFw j11i0eROqFUCEt8mH2KBaJWV2HQAGhCSEgdX3GCZwCgxC8niWUgWz0KyeBaSFQsYWVYxiqYW JBcUJ6UXmegVJ+YWl+al6yXn525ihETrhB2M9w5YH2JMBlo/kVlKNDkfGO15JfGGxmZGFqYm psZG5pZmpAkrifOqPUoKEhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cDI7jZjxgZ1jkWVKmu3 budMUd8cvtT3h3aNJlPMY+fFr106WVVrF/8qTrq0ZsHOqOyFHc+uvv4bdTeg8FjxkaDJ964m LxUIYzBeeYbLSNyaMYXZtjzWaXen7eGDTpcyl3z4OEVw/+7AXXb9cyo6Kvl/MmgeufCC+0X0 0UrziianfZVctdVfPhUpsRRnJBpqMRcVJwIARuuqS+wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsVy+t9jAd1Pi3YHGRzep2tx5MJaZouXhzQt Jq6czGxxeeElVotdjb9ZLXY3LWN3YPNY8Gsri8fOWXfZPTav0PLYvKTeo2/LKsYA1qgGRpuM 1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoAOUFMoSc0qB QgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYR1jBkXlwgW/GSvmL/nO2sD4x62LkZODgkB E4nXTxYwQ9hiEhfurQeKc3EICSxilHjev4YRwvnFKNG6ox+sg01ATeLLl8PsXYwcHCICBhI/ 3mSC1DAL9DNK7O+/yARSIyRgKzF36xWwek4BO4n5T+eA2cICXhL7npxnB7FZBFQlzixtYgGx eYHqr51bwQRhC0r8mHwPLM4soCWxfudxJghbXmLzmrfMIHslBNQlHv3VhTjBSGLhamGIChGJ fS/eMU5gFJqFZNAsJINmIRk0C0nLAkaWVYyiqQXJBcVJ6bmGesWJucWleel6yfm5mxjBqeCZ 1A7GlQ0WhxgFOBiVeHg7dHcHCbEmlhVX5h5ilOBgVhLh3dUNFOJNSaysSi3Kjy8qzUktPsSY DPTnRGYp0eR8YJrKK4k3NDYxM7I0MrMwMjE3J01YSZz3QKt1oJBAemJJanZqakFqEcwWJg5O qQZGpZnBbo9TQ6yXKuX9ltl8Mi16k8AB8UneQrOm7jH+/lfhheGCNG69J+s+s659dURF+Xqc k+2L2RMLf1qsiU3LLVA78bPBeNry5y+crU/tTK7acvSFWLDDzkrd1nkFRrvCPV501Bxy7bxk MnvHrWk3Zq3nURa+IMI/4d26leEa/fue5Ryb+2NRixJLcUaioRZzUXEiAGMDQXtJAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131225_223121_041529_21A37F00 X-CRM114-Status: UNSURE ( 8.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.5 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.24 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-mtd@lists.infradead.org, 'Jingoo Han' , 'David Woodhouse' , 'Josh Wu' X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Use dev_err() instead of printk() to provide a better message to userspace. Signed-off-by: Jingoo Han Acked-by: Josh Wu --- Change since v1 - Remove the site-specific OOM messages. drivers/mtd/nand/atmel_nand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index e633c44..c36e9b8 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -2060,14 +2060,14 @@ static int atmel_nand_probe(struct platform_device *pdev) } if (gpio_get_value(host->board.det_pin)) { - printk(KERN_INFO "No SmartMedia card inserted.\n"); + dev_info(&pdev->dev, "No SmartMedia card inserted.\n"); res = -ENXIO; goto err_no_card; } } if (host->board.on_flash_bbt || on_flash_bbt) { - printk(KERN_INFO "atmel_nand: Use On Flash BBT\n"); + dev_info(&pdev->dev, "Use On Flash BBT\n"); nand_chip->bbt_options |= NAND_BBT_USE_FLASH; }