Patchwork [13/23] mtd: pasemi_nand: Remove unnecessary OOM messages

login
register
mail settings
Submitter Jingoo Han
Date Dec. 26, 2013, 3:11 a.m.
Message ID <008f01cf01e8$21a7a8b0$64f6fa10$%han@samsung.com>
Download mbox | patch
Permalink /patch/305174/
State New
Headers show

Comments

Jingoo Han - Dec. 26, 2013, 3:11 a.m.
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/mtd/nand/pasemi_nand.c |    2 --
 1 file changed, 2 deletions(-)
Olof Johansson - Dec. 27, 2013, 5:43 a.m.
On Wed, Dec 25, 2013 at 7:11 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Actually -- the pasemi platform is barely used these days, and the
users I am aware of do not use the nand driver. I think we'd just fine
with removing it. I'll submit a patch to do so instead.



-Olof
Jingoo Han - Dec. 27, 2013, 5:49 a.m.
On Friday, December 27, 2013 2:43 PM, Olof Johansson wrote:
> On Wed, Dec 25, 2013 at 7:11 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > The site-specific OOM messages are unnecessary, because they
> > duplicate the MM subsystem generic OOM message.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> 
> Actually -- the pasemi platform is barely used these days, and the
> users I am aware of do not use the nand driver. I think we'd just fine
> with removing it. I'll submit a patch to do so instead.

Brian Norris,

Please ignore this patch, because the pasemi nand driver will
be removed by Olof Johansson. Thank you.

Best regards,
Jingoo Han

Patch

diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
index 90f871a..24cf045 100644
--- a/drivers/mtd/nand/pasemi_nand.c
+++ b/drivers/mtd/nand/pasemi_nand.c
@@ -114,8 +114,6 @@  static int pasemi_nand_probe(struct platform_device *ofdev)
 	pasemi_nand_mtd = kzalloc(sizeof(struct mtd_info) +
 				  sizeof(struct nand_chip), GFP_KERNEL);
 	if (!pasemi_nand_mtd) {
-		printk(KERN_WARNING
-		       "Unable to allocate PASEMI NAND MTD device structure\n");
 		err = -ENOMEM;
 		goto out;
 	}