| Message ID | 52B96FA7.10201@huawei.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2013-12-24 at 19:27 +0800, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal_unaligned > to instead of memcmp. Hi again Ding. > diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c [] > @@ -1668,7 +1668,7 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev) [] > - if (memcmp(promaddr, dev->dev_addr, ETH_ALEN) || > + if (!ether_addr_equal(promaddr, dev->dev_addr) || Can you please make sure the commit message matches the code changes? This uses ether_addr_equal not ether_addr_equal_unaligned. Thanks for the work. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
于 2013/12/24 20:38, Joe Perches 写道: > On Tue, 2013-12-24 at 19:27 +0800, Ding Tianhong wrote: >> Use possibly more efficient ether_addr_equal_unaligned >> to instead of memcmp. > > Hi again Ding. > >> diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c > [] >> @@ -1668,7 +1668,7 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev) > [] >> - if (memcmp(promaddr, dev->dev_addr, ETH_ALEN) || >> + if (!ether_addr_equal(promaddr, dev->dev_addr) || > > Can you please make sure the commit message matches the > code changes? > > This uses ether_addr_equal not ether_addr_equal_unaligned. > > Thanks for the work. > Oh， no, maybe I was dizzy by these patches, I should be more careful, sorry about that, I will resend this one. Regards Ding > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ding Tianhong <dthxman@gmail.com> Date: Tue, 24 Dec 2013 21:47:30 +0800 > Oh， no, maybe I was dizzy by these patches, I should be more careful, > sorry about that, I will resend this one. You must resend the entire patch series when you make any changes. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013/12/25 1:59, David Miller wrote: > From: Ding Tianhong <dthxman@gmail.com> > Date: Tue, 24 Dec 2013 21:47:30 +0800 > >> Oh， no, maybe I was dizzy by these patches, I should be more careful, >> sorry about that, I will resend this one. > > You must resend the entire patch series when you make any changes. > > Thank you. > > ok -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index 38492e0..9339ccc 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -1668,7 +1668,7 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev) for (i = 0; i < ETH_ALEN; i++) promaddr[i] = inb(ioaddr + i); - if (memcmp(promaddr, dev->dev_addr, ETH_ALEN) || + if (!ether_addr_equal(promaddr, dev->dev_addr) || !is_valid_ether_addr(dev->dev_addr)) { if (is_valid_ether_addr(promaddr)) { if (pcnet32_debug & NETIF_MSG_PROBE) {
Use possibly more efficient ether_addr_equal_unaligned to instead of memcmp. Cc: Don Fry <pcnet32@frontier.com> Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> --- drivers/net/ethernet/amd/pcnet32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)