| Message ID | 21175198efaf34a67e5108c1dae384656012b7a0.1387833347.git.josh@joshtriplett.org |
|---|---|
| State | Accepted |
| Commit | 88c305912db5d50e2b2568e22119b9ee3b56ad88 |
| Headers | show |
On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote: > > The kernel already has this information, and individual drivers > shouldn't duplicate that. This also eliminates the use of __DATE__ and > __TIME__, which make the build non-deterministic. > > Signed-off-by: Josh Triplett <josh@joshtriplett.org> (+cc Dinh Nguyen) It looks good. :-) Reviewed-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > drivers/mtd/nand/denali_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c > index 033f177..ab64416 100644 > --- a/drivers/mtd/nand/denali_pci.c > +++ b/drivers/mtd/nand/denali_pci.c > @@ -131,7 +131,6 @@ static struct pci_driver denali_pci_driver = { > > static int denali_init_pci(void) > { > - pr_info("Spectra MTD driver built on %s @ %s\n", __DATE__, __TIME__); > return pci_register_driver(&denali_pci_driver); > } > module_init(denali_init_pci); > -- > 1.8.5.2
On Thu, Dec 26, 2013 at 05:24:53PM +0900, Jingoo Han wrote: > On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote: > > > > The kernel already has this information, and individual drivers > > shouldn't duplicate that. BTW, it is possible for modules to be built at a different time than the kernel, and this code could show that. But it's not very useful anyway, so I agree. > > This also eliminates the use of __DATE__ and > > __TIME__, which make the build non-deterministic. > > > > Signed-off-by: Josh Triplett <josh@joshtriplett.org> > > (+cc Dinh Nguyen) > > It looks good. :-) > Reviewed-by: Jingoo Han <jg1.han@samsung.com> Thanks. Pushed to l2-mtd.git. Brian
diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c index 033f177..ab64416 100644 --- a/drivers/mtd/nand/denali_pci.c +++ b/drivers/mtd/nand/denali_pci.c @@ -131,7 +131,6 @@ static struct pci_driver denali_pci_driver = { static int denali_init_pci(void) { - pr_info("Spectra MTD driver built on %s @ %s\n", __DATE__, __TIME__); return pci_register_driver(&denali_pci_driver); } module_init(denali_init_pci);
The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by: Josh Triplett <josh@joshtriplett.org> --- drivers/mtd/nand/denali_pci.c | 1 - 1 file changed, 1 deletion(-)