| Message ID | 1387785093-2885-1-git-send-email-B45475@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
On 12/22/2013 11:51 PM, Zhao Qiang wrote: > Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" before > while "if (phydev->supported & SUPPORTED_Autoneg)" now. > So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033 > to enable autonegotiation. > > Signed-off-by: Zhao Qiang <B45475@freescale.com> > --- > drivers/net/phy/atheros.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c > index b20b4df..1ee2226 100644 > --- a/drivers/net/phy/atheros.c > +++ b/drivers/net/phy/atheros.c > @@ -13,6 +13,7 @@ static int ar8021_config(struct phy_device *phydev) > phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05); > phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x3D47); > > + phydev->supported = phydev->drv->features; > return 0; > } > > Joe, This patch has been floating for a while. If it is OK, I'd like to take it in with other 85xx patches. York
On 12/22/2013 11:51 PM, Zhao Qiang wrote: > Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" before > while "if (phydev->supported & SUPPORTED_Autoneg)" now. > So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033 > to enable autonegotiation. > > Signed-off-by: Zhao Qiang <B45475@freescale.com> > --- Applied to u-boot-mpc85xx/master. Thanks. York
On Mon, Feb 24, 2014 at 5:54 PM, York Sun <yorksun@freescale.com> wrote: > On 12/22/2013 11:51 PM, Zhao Qiang wrote: > > Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" > before > > while "if (phydev->supported & SUPPORTED_Autoneg)" now. > > So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033 > > to enable autonegotiation. > > > > Signed-off-by: Zhao Qiang <B45475@freescale.com> > > --- > > drivers/net/phy/atheros.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c > > index b20b4df..1ee2226 100644 > > --- a/drivers/net/phy/atheros.c > > +++ b/drivers/net/phy/atheros.c > > @@ -13,6 +13,7 @@ static int ar8021_config(struct phy_device *phydev) > > phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05); > > phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x3D47); > > > > + phydev->supported = phydev->drv->features; > > return 0; > > } > > > > > > Joe, > > This patch has been floating for a while. If it is OK, I'd like to take it > in > with other 85xx patches. > > Sorry for the delayed response... This change seems fine. -Joe
diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index b20b4df..1ee2226 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@ -13,6 +13,7 @@ static int ar8021_config(struct phy_device *phydev) phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05); phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x3D47); + phydev->supported = phydev->drv->features; return 0; }
Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" before while "if (phydev->supported & SUPPORTED_Autoneg)" now. So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033 to enable autonegotiation. Signed-off-by: Zhao Qiang <B45475@freescale.com> --- drivers/net/phy/atheros.c | 1 + 1 file changed, 1 insertion(+)