| Message ID | 1387722749-29348-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
On 22 December 2013 14:32, Stefan Weil <sw@weilnetz.de> wrote: > The row and column values use only a very limited range (-1 ... 7), > so a byte value is sufficient. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> It's not like we have a ton of pxa2xx keymaps eating up space, but yeah, this is an OK change. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
22.12.2013 18:32, Stefan Weil wrote: > The row and column values use only a very limited range (-1 ... 7), > so a byte value is sufficient. Thanks, applied to the trivial-patches queue. /mjt
diff --git a/include/hw/arm/pxa.h b/include/hw/arm/pxa.h index d146c58..7ca330a 100644 --- a/include/hw/arm/pxa.h +++ b/include/hw/arm/pxa.h @@ -102,8 +102,8 @@ void pxa2xx_pcmcia_set_irq_cb(void *opaque, qemu_irq irq, qemu_irq cd_irq); /* pxa2xx_keypad.c */ struct keymap { - int column; - int row; + int8_t column; + int8_t row; }; typedef struct PXA2xxKeyPadState PXA2xxKeyPadState; PXA2xxKeyPadState *pxa27x_keypad_init(MemoryRegion *sysmem,
The row and column values use only a very limited range (-1 ... 7), so a byte value is sufficient. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- include/hw/arm/pxa.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)