Message ID | c2aaf067-88c4-405a-af3c-ada13e32541d@DB9EHSMHS028.ehs.local |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
Hi Jagan, On Saturday 21 December 2013 12:50 PM, Jagannadha Sutradharudu Teki wrote: > From: Jagannadha Sutradharudu Teki<jagannadha.sutradharudu-teki@xilinx.com> > > From: "Poddar, Sourav"<sourav.poddar@ti.com> > > Add QSPI definitions and clock configuration support. > > Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> > Reviewed-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com> > --- > V3: Added review tag > V2: > > arch/arm/cpu/armv7/am33xx/clock_am43xx.c | 1 + > arch/arm/include/asm/arch-am33xx/cpu.h | 4 +++- > arch/arm/include/asm/arch-am33xx/omap.h | 1 + > 3 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c > index 97c00b4..fb654bb 100644 > --- a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c > +++ b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c > @@ -98,6 +98,7 @@ void enable_basic_clocks(void) > &cmper->emiffwclkctrl, > &cmper->emifclkctrl, > &cmper->otfaemifclkctrl, > + &cmper->qspiclkctrl, > 0 > }; > > diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h b/arch/arm/include/asm/arch-am33xx/cpu.h > index 9febfa2..0736258 100644 > --- a/arch/arm/include/asm/arch-am33xx/cpu.h > +++ b/arch/arm/include/asm/arch-am33xx/cpu.h > @@ -332,7 +332,9 @@ struct cm_perpll { > unsigned int mcasp1clkctrl; /* offset 0x240 */ > unsigned int resv11; > unsigned int mmc2clkctrl; /* offset 0x248 */ > - unsigned int resv12[5]; > + unsigned int resv12[3]; > + unsigned int qspiclkctrl; /* offset 0x258 */ > + unsigned int resv121; > unsigned int usb0clkctrl; /* offset 0x260 */ > unsigned int resv13[103]; > unsigned int l4lsclkstctrl; /* offset 0x400 */ > diff --git a/arch/arm/include/asm/arch-am33xx/omap.h b/arch/arm/include/asm/arch-am33xx/omap.h > index 7a7d91b..0855d16 100644 > --- a/arch/arm/include/asm/arch-am33xx/omap.h > +++ b/arch/arm/include/asm/arch-am33xx/omap.h > @@ -29,5 +29,6 @@ > #define SRAM_SCRATCH_SPACE_ADDR 0x40337C00 > #define AM4372_BOARD_NAME_START SRAM_SCRATCH_SPACE_ADDR > #define AM4372_BOARD_NAME_END SRAM_SCRATCH_SPACE_ADDR + 0xC > +#define QSPI_BASE 0x47900000 > #endif > #endif > > This looks Ok to me. How you want this to go? I mean as Tom suggested in some earlier version through his tree? or yours?
Hi Sourav, On Mon, Jan 6, 2014 at 12:10 PM, Sourav Poddar <sourav.poddar@ti.com> wrote: > Hi Jagan, > > On Saturday 21 December 2013 12:50 PM, Jagannadha Sutradharudu Teki wrote: >> >> From: Jagannadha Sutradharudu >> Teki<jagannadha.sutradharudu-teki@xilinx.com> >> >> From: "Poddar, Sourav"<sourav.poddar@ti.com> >> >> Add QSPI definitions and clock configuration support. >> >> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> >> Reviewed-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com> >> --- >> V3: Added review tag >> V2: >> >> arch/arm/cpu/armv7/am33xx/clock_am43xx.c | 1 + >> arch/arm/include/asm/arch-am33xx/cpu.h | 4 +++- >> arch/arm/include/asm/arch-am33xx/omap.h | 1 + >> 3 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >> b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >> index 97c00b4..fb654bb 100644 >> --- a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >> +++ b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >> @@ -98,6 +98,7 @@ void enable_basic_clocks(void) >> &cmper->emiffwclkctrl, >> &cmper->emifclkctrl, >> &cmper->otfaemifclkctrl, >> + &cmper->qspiclkctrl, >> 0 >> }; >> >> diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h >> b/arch/arm/include/asm/arch-am33xx/cpu.h >> index 9febfa2..0736258 100644 >> --- a/arch/arm/include/asm/arch-am33xx/cpu.h >> +++ b/arch/arm/include/asm/arch-am33xx/cpu.h >> @@ -332,7 +332,9 @@ struct cm_perpll { >> unsigned int mcasp1clkctrl; /* offset 0x240 */ >> unsigned int resv11; >> unsigned int mmc2clkctrl; /* offset 0x248 */ >> - unsigned int resv12[5]; >> + unsigned int resv12[3]; >> + unsigned int qspiclkctrl; /* offset 0x258 */ >> + unsigned int resv121; >> unsigned int usb0clkctrl; /* offset 0x260 */ >> unsigned int resv13[103]; >> unsigned int l4lsclkstctrl; /* offset 0x400 */ >> diff --git a/arch/arm/include/asm/arch-am33xx/omap.h >> b/arch/arm/include/asm/arch-am33xx/omap.h >> index 7a7d91b..0855d16 100644 >> --- a/arch/arm/include/asm/arch-am33xx/omap.h >> +++ b/arch/arm/include/asm/arch-am33xx/omap.h >> @@ -29,5 +29,6 @@ >> #define SRAM_SCRATCH_SPACE_ADDR 0x40337C00 >> #define AM4372_BOARD_NAME_START SRAM_SCRATCH_SPACE_ADDR >> #define AM4372_BOARD_NAME_END SRAM_SCRATCH_SPACE_ADDR + 0xC >> +#define QSPI_BASE 0x47900000 >> #endif >> #endif >> >> > This looks Ok to me. > How you want this to go? > I mean as Tom suggested in some earlier version through his tree? or yours? > Tom told in earlier that - he will take this series as there are some conflicts w.r.t u-boot-ti http://u-boot.10912.n7.nabble.com/UBOOT-PATCHv2-0-5-qspi-Add-AM437x-support-td170188.html I sent this series again to fix one warning and added Reviewed-by tag.
On Monday 06 January 2014 01:06 PM, Jagan Teki wrote: > Hi Sourav, > > On Mon, Jan 6, 2014 at 12:10 PM, Sourav Poddar<sourav.poddar@ti.com> wrote: >> Hi Jagan, >> >> On Saturday 21 December 2013 12:50 PM, Jagannadha Sutradharudu Teki wrote: >>> From: Jagannadha Sutradharudu >>> Teki<jagannadha.sutradharudu-teki@xilinx.com> >>> >>> From: "Poddar, Sourav"<sourav.poddar@ti.com> >>> >>> Add QSPI definitions and clock configuration support. >>> >>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> >>> Reviewed-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com> >>> --- >>> V3: Added review tag >>> V2: >>> >>> arch/arm/cpu/armv7/am33xx/clock_am43xx.c | 1 + >>> arch/arm/include/asm/arch-am33xx/cpu.h | 4 +++- >>> arch/arm/include/asm/arch-am33xx/omap.h | 1 + >>> 3 files changed, 5 insertions(+), 1 deletions(-) >>> >>> diff --git a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>> b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>> index 97c00b4..fb654bb 100644 >>> --- a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>> +++ b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>> @@ -98,6 +98,7 @@ void enable_basic_clocks(void) >>> &cmper->emiffwclkctrl, >>> &cmper->emifclkctrl, >>> &cmper->otfaemifclkctrl, >>> +&cmper->qspiclkctrl, >>> 0 >>> }; >>> >>> diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h >>> b/arch/arm/include/asm/arch-am33xx/cpu.h >>> index 9febfa2..0736258 100644 >>> --- a/arch/arm/include/asm/arch-am33xx/cpu.h >>> +++ b/arch/arm/include/asm/arch-am33xx/cpu.h >>> @@ -332,7 +332,9 @@ struct cm_perpll { >>> unsigned int mcasp1clkctrl; /* offset 0x240 */ >>> unsigned int resv11; >>> unsigned int mmc2clkctrl; /* offset 0x248 */ >>> - unsigned int resv12[5]; >>> + unsigned int resv12[3]; >>> + unsigned int qspiclkctrl; /* offset 0x258 */ >>> + unsigned int resv121; >>> unsigned int usb0clkctrl; /* offset 0x260 */ >>> unsigned int resv13[103]; >>> unsigned int l4lsclkstctrl; /* offset 0x400 */ >>> diff --git a/arch/arm/include/asm/arch-am33xx/omap.h >>> b/arch/arm/include/asm/arch-am33xx/omap.h >>> index 7a7d91b..0855d16 100644 >>> --- a/arch/arm/include/asm/arch-am33xx/omap.h >>> +++ b/arch/arm/include/asm/arch-am33xx/omap.h >>> @@ -29,5 +29,6 @@ >>> #define SRAM_SCRATCH_SPACE_ADDR 0x40337C00 >>> #define AM4372_BOARD_NAME_START SRAM_SCRATCH_SPACE_ADDR >>> #define AM4372_BOARD_NAME_END SRAM_SCRATCH_SPACE_ADDR + 0xC >>> +#define QSPI_BASE 0x47900000 >>> #endif >>> #endif >>> >>> >> This looks Ok to me. >> How you want this to go? >> I mean as Tom suggested in some earlier version through his tree? or yours? >> > Tom told in earlier that - he will take this series as there are some > conflicts w.r.t u-boot-ti > http://u-boot.10912.n7.nabble.com/UBOOT-PATCHv2-0-5-qspi-Add-AM437x-support-td170188.html > > I sent this series again to fix one warning and added Reviewed-by tag. > Ok thanks, Tom, Can you pick this one?
On Mon, Jan 6, 2014 at 1:51 PM, Sourav Poddar <sourav.poddar@ti.com> wrote: > On Monday 06 January 2014 01:06 PM, Jagan Teki wrote: >> >> Hi Sourav, >> >> On Mon, Jan 6, 2014 at 12:10 PM, Sourav Poddar<sourav.poddar@ti.com> >> wrote: >>> >>> Hi Jagan, >>> >>> On Saturday 21 December 2013 12:50 PM, Jagannadha Sutradharudu Teki >>> wrote: >>>> >>>> From: Jagannadha Sutradharudu >>>> Teki<jagannadha.sutradharudu-teki@xilinx.com> >>>> >>>> From: "Poddar, Sourav"<sourav.poddar@ti.com> >>>> >>>> Add QSPI definitions and clock configuration support. >>>> >>>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> >>>> Reviewed-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com> >>>> --- >>>> V3: Added review tag >>>> V2: >>>> >>>> arch/arm/cpu/armv7/am33xx/clock_am43xx.c | 1 + >>>> arch/arm/include/asm/arch-am33xx/cpu.h | 4 +++- >>>> arch/arm/include/asm/arch-am33xx/omap.h | 1 + >>>> 3 files changed, 5 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>>> b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>>> index 97c00b4..fb654bb 100644 >>>> --- a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>>> +++ b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c >>>> @@ -98,6 +98,7 @@ void enable_basic_clocks(void) >>>> &cmper->emiffwclkctrl, >>>> &cmper->emifclkctrl, >>>> &cmper->otfaemifclkctrl, >>>> +&cmper->qspiclkctrl, >>>> >>>> 0 >>>> }; >>>> >>>> diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h >>>> b/arch/arm/include/asm/arch-am33xx/cpu.h >>>> index 9febfa2..0736258 100644 >>>> --- a/arch/arm/include/asm/arch-am33xx/cpu.h >>>> +++ b/arch/arm/include/asm/arch-am33xx/cpu.h >>>> @@ -332,7 +332,9 @@ struct cm_perpll { >>>> unsigned int mcasp1clkctrl; /* offset 0x240 */ >>>> unsigned int resv11; >>>> unsigned int mmc2clkctrl; /* offset 0x248 */ >>>> - unsigned int resv12[5]; >>>> + unsigned int resv12[3]; >>>> + unsigned int qspiclkctrl; /* offset 0x258 */ >>>> + unsigned int resv121; >>>> unsigned int usb0clkctrl; /* offset 0x260 */ >>>> unsigned int resv13[103]; >>>> unsigned int l4lsclkstctrl; /* offset 0x400 */ >>>> diff --git a/arch/arm/include/asm/arch-am33xx/omap.h >>>> b/arch/arm/include/asm/arch-am33xx/omap.h >>>> index 7a7d91b..0855d16 100644 >>>> --- a/arch/arm/include/asm/arch-am33xx/omap.h >>>> +++ b/arch/arm/include/asm/arch-am33xx/omap.h >>>> @@ -29,5 +29,6 @@ >>>> #define SRAM_SCRATCH_SPACE_ADDR 0x40337C00 >>>> #define AM4372_BOARD_NAME_START SRAM_SCRATCH_SPACE_ADDR >>>> #define AM4372_BOARD_NAME_END SRAM_SCRATCH_SPACE_ADDR + 0xC >>>> +#define QSPI_BASE 0x47900000 >>>> #endif >>>> #endif >>>> >>>> >>> This looks Ok to me. >>> How you want this to go? >>> I mean as Tom suggested in some earlier version through his tree? or >>> yours? >>> >> Tom told in earlier that - he will take this series as there are some >> conflicts w.r.t u-boot-ti >> >> http://u-boot.10912.n7.nabble.com/UBOOT-PATCHv2-0-5-qspi-Add-AM437x-support-td170188.html >> >> I sent this series again to fix one warning and added Reviewed-by tag. >> > Ok thanks, > > Tom, > > Can you pick this one? fyi: I just marked these series to Tom as a delegate.
diff --git a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c index 97c00b4..fb654bb 100644 --- a/arch/arm/cpu/armv7/am33xx/clock_am43xx.c +++ b/arch/arm/cpu/armv7/am33xx/clock_am43xx.c @@ -98,6 +98,7 @@ void enable_basic_clocks(void) &cmper->emiffwclkctrl, &cmper->emifclkctrl, &cmper->otfaemifclkctrl, + &cmper->qspiclkctrl, 0 }; diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h b/arch/arm/include/asm/arch-am33xx/cpu.h index 9febfa2..0736258 100644 --- a/arch/arm/include/asm/arch-am33xx/cpu.h +++ b/arch/arm/include/asm/arch-am33xx/cpu.h @@ -332,7 +332,9 @@ struct cm_perpll { unsigned int mcasp1clkctrl; /* offset 0x240 */ unsigned int resv11; unsigned int mmc2clkctrl; /* offset 0x248 */ - unsigned int resv12[5]; + unsigned int resv12[3]; + unsigned int qspiclkctrl; /* offset 0x258 */ + unsigned int resv121; unsigned int usb0clkctrl; /* offset 0x260 */ unsigned int resv13[103]; unsigned int l4lsclkstctrl; /* offset 0x400 */ diff --git a/arch/arm/include/asm/arch-am33xx/omap.h b/arch/arm/include/asm/arch-am33xx/omap.h index 7a7d91b..0855d16 100644 --- a/arch/arm/include/asm/arch-am33xx/omap.h +++ b/arch/arm/include/asm/arch-am33xx/omap.h @@ -29,5 +29,6 @@ #define SRAM_SCRATCH_SPACE_ADDR 0x40337C00 #define AM4372_BOARD_NAME_START SRAM_SCRATCH_SPACE_ADDR #define AM4372_BOARD_NAME_END SRAM_SCRATCH_SPACE_ADDR + 0xC +#define QSPI_BASE 0x47900000 #endif #endif