diff mbox

[v2] powerpc/512x: dts: disable MPC5125 usb module

Message ID 1387530982-6115-1-git-send-email-matteo.facchinetti@sirius-es.it (mailing list archive)
State Accepted, archived
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Matteo Facchinetti Dec. 20, 2013, 9:16 a.m. UTC
At the moment the USB controller's pin muxing is not setup
correctly and causes a kernel panic upon system startup, so
disable the USB1 device tree node in the MPC5125 tower board
dts file.

The USB controller is connected to an USB3320 ULPI transceiver
and the device tree should receive an update to reflect correct
dependencies and required initialization data before the USB1
node can get re-enabled.

Signed-off-by: Matteo Facchinetti <matteo.facchinetti@sirius-es.it>
---
v2:
* improve the text of the commit as suggested by Gerhard Sittig <gsi@denx.de>
* put the 'status = "disabled"' to the last line in the list of properties
* rewiew the comment related to USB1 device tree node
---
 arch/powerpc/boot/dts/mpc5125twr.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Anatolij Gustschin Dec. 20, 2013, 9:16 p.m. UTC | #1
On Fri, 20 Dec 2013 10:16:22 +0100
Matteo Facchinetti <matteo.facchinetti@sirius-es.it> wrote:

> At the moment the USB controller's pin muxing is not setup
> correctly and causes a kernel panic upon system startup, so
> disable the USB1 device tree node in the MPC5125 tower board
> dts file.
> 
> The USB controller is connected to an USB3320 ULPI transceiver
> and the device tree should receive an update to reflect correct
> dependencies and required initialization data before the USB1
> node can get re-enabled.
> 
> Signed-off-by: Matteo Facchinetti <matteo.facchinetti@sirius-es.it>
> ---
> v2:
> * improve the text of the commit as suggested by Gerhard Sittig <gsi@denx.de>
> * put the 'status = "disabled"' to the last line in the list of properties
> * rewiew the comment related to USB1 device tree node
> ---
>  arch/powerpc/boot/dts/mpc5125twr.dts | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to merge branch. Thanks!

Anatolij
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/mpc5125twr.dts b/arch/powerpc/boot/dts/mpc5125twr.dts
index 806479f..2fa1d17 100644
--- a/arch/powerpc/boot/dts/mpc5125twr.dts
+++ b/arch/powerpc/boot/dts/mpc5125twr.dts
@@ -229,6 +229,10 @@ 
 			reg = <0xA000 0x1000>;
 		};
 
+		// disable USB1 port
+		// TODO:
+		// correct pinmux config and fix USB3320 ulpi dependency
+		// before re-enable it
 		usb@3000 {
 			compatible = "fsl,mpc5121-usb2-dr";
 			reg = <0x3000 0x400>;
@@ -239,6 +243,7 @@ 
 			phy_type = "ulpi";
 			clocks = <&clks MPC512x_CLK_USB1>;
 			clock-names = "ipg";
+			status = "disabled";
 		};
 
 		// 5125 PSCs are not 52xx or 5121 PSC compatible