diff mbox

[U-Boot] powerpc/83xx: fix compilation error for MPC8315ERDB

Message ID 1387511680-13918-1-git-send-email-B46172@freescale.com
State Superseded
Delegated to: York Sun
Headers show

Commit Message

Nikhil Badola Dec. 20, 2013, 3:54 a.m. UTC 
From: Ramneek Mehresh <ramneek.mehresh@freescale.com>

Defines get_svr() for 83xx devices

Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
---
 arch/powerpc/cpu/mpc83xx/start.S | 5 +++++
 1 file changed, 5 insertions(+)

Comments

York Sun Jan. 2, 2014, 9:44 p.m. UTC | #1 
On 12/19/2013 07:54 PM, Nikhil Badola wrote:
> From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> 
> Defines get_svr() for 83xx devices
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  arch/powerpc/cpu/mpc83xx/start.S | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
> index b4fafe6..7f74a50 100644
> --- a/arch/powerpc/cpu/mpc83xx/start.S
> +++ b/arch/powerpc/cpu/mpc83xx/start.S
> @@ -120,6 +120,11 @@ disable_addr_trans:
>  	mtspr	SRR1, r3
>  	rfi
>  
> +	.globl get_svr
> +get_svr:
> +	mfspr	r3, SVR
> +	blr
> +
>  	.globl get_pvr
>  get_pvr:
>  	mfspr	r3, PVR
> 

Please share how to reproduce the compilation error. I don't see it.

York
Scott Wood Jan. 3, 2014, 7:27 p.m. UTC | #2 
On Fri, 2013-12-20 at 09:24 +0530, Nikhil Badola wrote:
> From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> 
> Defines get_svr() for 83xx devices
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  arch/powerpc/cpu/mpc83xx/start.S | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
> index b4fafe6..7f74a50 100644
> --- a/arch/powerpc/cpu/mpc83xx/start.S
> +++ b/arch/powerpc/cpu/mpc83xx/start.S
> @@ -120,6 +120,11 @@ disable_addr_trans:
>  	mtspr	SRR1, r3
>  	rfi
>  
> +	.globl get_svr
> +get_svr:
> +	mfspr	r3, SVR
> +	blr
> +
>  	.globl get_pvr
>  get_pvr:
>  	mfspr	r3, PVR

Instead of this, how about turning these into straightforward
non-subarch-specific inline functions?

-Scott
diff mbox

Patch

diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
index b4fafe6..7f74a50 100644
--- a/arch/powerpc/cpu/mpc83xx/start.S
+++ b/arch/powerpc/cpu/mpc83xx/start.S
@@ -120,6 +120,11 @@  disable_addr_trans:
 	mtspr	SRR1, r3
 	rfi
 
+	.globl get_svr
+get_svr:
+	mfspr	r3, SVR
+	blr
+
 	.globl get_pvr
 get_pvr:
 	mfspr	r3, PVR