| Message ID | 1387514323-4486-2-git-send-email-Larry.Finger@lwfinger.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
With this series applied, I get a ton of "unused variable" warnings, can you please fix them up now too? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/20/2013 10:58 AM, Greg KH wrote: > With this series applied, I get a ton of "unused variable" warnings, can > you please fix them up now too? Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909 [gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you using? Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote: > On 12/20/2013 10:58 AM, Greg KH wrote: > > With this series applied, I get a ton of "unused variable" warnings, can > > you please fix them up now too? > > Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909 > [gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you using? > I'm using an older version: $ gcc --version gcc (Gentoo 4.7.3-r1 p1.3, pie-0.5.5) 4.7.3 Odd. I'll move up to 4.8 and try that... Nope, same problem, here's one example line: drivers/staging/rtl8188eu/core/rtw_ap.c: In function ‘rtw_ap_inform_ch_switch’: drivers/staging/rtl8188eu/core/rtw_ap.c:1773:16: warning: unused variable ‘irqL’ [-Wunused-variable] unsigned long irqL; This is x86-64, could that be an issue? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/20/2013 01:18 PM, Greg KH wrote: > On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote: >> On 12/20/2013 10:58 AM, Greg KH wrote: >>> With this series applied, I get a ton of "unused variable" warnings, can >>> you please fix them up now too? >> >> Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909 >> [gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you using? >> > > I'm using an older version: > $ gcc --version > gcc (Gentoo 4.7.3-r1 p1.3, pie-0.5.5) 4.7.3 > > Odd. I'll move up to 4.8 and try that... > > Nope, same problem, here's one example line: > drivers/staging/rtl8188eu/core/rtw_ap.c: In function ‘rtw_ap_inform_ch_switch’: > drivers/staging/rtl8188eu/core/rtw_ap.c:1773:16: warning: unused variable ‘irqL’ [-Wunused-variable] > unsigned long irqL; > > This is x86-64, could that be an issue? Mine is x86_64 as well. I see the extra lines for "irqL" that gcc 4.7 finds but 4.8 misses. You should probably stay at 4.7 to catch the things that 4.8 misses. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 20, 2013 at 02:30:39PM -0600, Larry Finger wrote: > On 12/20/2013 01:18 PM, Greg KH wrote: > > On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote: > >> On 12/20/2013 10:58 AM, Greg KH wrote: > >>> With this series applied, I get a ton of "unused variable" warnings, can > >>> you please fix them up now too? > >> > >> Strange, but I don't get any. My compiler is gcc (SUSE Linux) 4.8.1 20130909 > >> [gcc-4_8-branch revision 202388] from openSUSE 13.1. What version are you using? > >> > > > > I'm using an older version: > > $ gcc --version > > gcc (Gentoo 4.7.3-r1 p1.3, pie-0.5.5) 4.7.3 > > > > Odd. I'll move up to 4.8 and try that... > > > > Nope, same problem, here's one example line: > > drivers/staging/rtl8188eu/core/rtw_ap.c: In function ‘rtw_ap_inform_ch_switch’: > > drivers/staging/rtl8188eu/core/rtw_ap.c:1773:16: warning: unused variable ‘irqL’ [-Wunused-variable] > > unsigned long irqL; > > > > This is x86-64, could that be an issue? > > Mine is x86_64 as well. > > I see the extra lines for "irqL" that gcc 4.7 finds but 4.8 misses. You should > probably stay at 4.7 to catch the things that 4.8 misses. Nah, I just switched to 4.8 and rebuilt all of the different kernel trees on this box with it, so I'll stay there for now. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/20/2013 02:34 PM, Greg KH wrote: > Nah, I just switched to 4.8 and rebuilt all of the different kernel > trees on this box with it, so I'll stay there for now. The problem wasn't the fault of gcc 4.8. I only use the staging tree to base patches to send to you, and my .config in that directory was missing one of the options for r8188eu. I have found what I think are all the unused variables in the driver. The patch will be sent shortly. Thanks, Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index f45f4ed..3e2d980 100644 --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c @@ -420,7 +420,7 @@ post_process: _func_exit_; - thread_exit(); + complete_and_exit(NULL, 0); } u8 rtw_setstandby_cmd(struct adapter *padapter, uint action) diff --git a/drivers/staging/rtl8188eu/core/rtw_mp.c b/drivers/staging/rtl8188eu/core/rtw_mp.c index 9832dcb..0204639 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mp.c +++ b/drivers/staging/rtl8188eu/core/rtw_mp.c @@ -643,7 +643,7 @@ exit: pmptx->pallocated_buf = NULL; pmptx->stop = 1; - thread_exit(); + complete_and_exit(NULL, 0); } void fill_txdesc_for_mp(struct adapter *padapter, struct tx_desc *ptxdesc) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index 46b34fc..ba790f0 100644 --- a/drivers/staging/rtl8188eu/include/osdep_service.h +++ b/drivers/staging/rtl8188eu/include/osdep_service.h @@ -62,8 +62,6 @@ struct __queue { spinlock_t lock; }; -#define thread_exit() complete_and_exit(NULL, 0) - static inline struct list_head *get_next(struct list_head *list) { return list->next;
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mp.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-)