diff mbox

[-next] drivers/rtc/rtc-hym8563.c: fix sparse non static symbol warning

Message ID CAPgLHd8JOtwqMmDC6AbE0m5_81mfzVbH4LH-iN5rOfiiF=S2xA@mail.gmail.com
State Rejected
Headers show

Commit Message

Wei Yongjun Dec. 20, 2013, 2:20 a.m. UTC
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fixes the following sparse warning:

drivers/rtc/rtc-hym8563.c:392:22: warning:
 symbol 'hym8563_clkout_ops' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/rtc/rtc-hym8563.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Stuebner Dec. 20, 2013, 8:19 a.m. UTC | #1
Am Freitag, 20. Dezember 2013, 03:20:46 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fixes the following sparse warning:
> 
> drivers/rtc/rtc-hym8563.c:392:22: warning:
>  symbol 'hym8563_clkout_ops' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

gah, thanks for the catch :-)

Acked-by: Heiko Stuebner <heiko@sntech.de>


> ---
>  drivers/rtc/rtc-hym8563.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
> index b56e3d3..65c5e72 100644
> --- a/drivers/rtc/rtc-hym8563.c
> +++ b/drivers/rtc/rtc-hym8563.c
> @@ -389,7 +389,7 @@ static int hym8563_clkout_is_prepared(struct clk_hw
> *hw) return !(ret & HYM8563_CLKOUT_DISABLE);
>  }
> 
> -const struct clk_ops hym8563_clkout_ops = {
> +static const struct clk_ops hym8563_clkout_ops = {
>  	.prepare = hym8563_clkout_prepare,
>  	.unprepare = hym8563_clkout_unprepare,
>  	.is_prepared = hym8563_clkout_is_prepared,
diff mbox

Patch

diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
index b56e3d3..65c5e72 100644
--- a/drivers/rtc/rtc-hym8563.c
+++ b/drivers/rtc/rtc-hym8563.c
@@ -389,7 +389,7 @@  static int hym8563_clkout_is_prepared(struct clk_hw *hw)
 	return !(ret & HYM8563_CLKOUT_DISABLE);
 }
 
-const struct clk_ops hym8563_clkout_ops = {
+static const struct clk_ops hym8563_clkout_ops = {
 	.prepare = hym8563_clkout_prepare,
 	.unprepare = hym8563_clkout_unprepare,
 	.is_prepared = hym8563_clkout_is_prepared,