Patchwork e2fsck: read only parameter incorrectly compared

login
register
mail settings
Submitter Theodore Ts'o
Date Dec. 19, 2013, 9:31 p.m.
Message ID <1387488703-18595-1-git-send-email-tytso@mit.edu>
Download mbox | patch
Permalink /patch/303748/
State Accepted
Headers show

Comments

Theodore Ts'o - Dec. 19, 2013, 9:31 p.m.
From: Johan Erlandsson <johan.erlandsson@sonyericsson.com>

Don't check for lost+found in read only mode.

[Note: this patch was originally made against 1.41.14 version of
e2fsprogs found as part of the AOSP (Android Open Source Program)
tree.  My Signed-off-by relies on the fact that the original patch
author would have had to have filed a contribution agreement with Open
Handset Alliance before this commit before this commit was allowed
into the AOSP tree. -- tytso]

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

Note: This patch was original authored on August 2, 2012.  It would have
been nice if had been sent directly to upstream earlier, but oh, well.
(This patch was sent to me via Google's Android team.)

I will apply it against the maint branch and it will be in the 1.42.9
release.

 e2fsck/pass3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/e2fsck/pass3.c b/e2fsck/pass3.c
index d87bd79..32c05b5 100644
--- a/e2fsck/pass3.c
+++ b/e2fsck/pass3.c
@@ -112,7 +112,7 @@  void e2fsck_pass3(e2fsck_t ctx)
 	/*
 	 * Force the creation of /lost+found if not present
 	 */
-	if ((ctx->flags & E2F_OPT_READONLY) == 0)
+	if ((ctx->options & E2F_OPT_READONLY) == 0)
 		e2fsck_get_lost_and_found(ctx, 1);
 
 	/*