diff mbox

[1/2] mfd: AS3722: add dt node properties for system power controller

Message ID 1387457821-12509-1-git-send-email-ldewangan@nvidia.com
State Superseded, archived
Headers show

Commit Message

Laxman Dewangan Dec. 19, 2013, 12:57 p.m. UTC
ams AS3722 device supports the power off by turning off its all rails.

Add dt node properties to enable this functionality on this device.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 Documentation/devicetree/bindings/mfd/as3722.txt |    9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Lee Jones Dec. 19, 2013, 1:06 p.m. UTC | #1
On Thu, 19 Dec 2013, Laxman Dewangan wrote:

> ams AS3722 device supports the power off by turning off its all rails.
> 
> Add dt node properties to enable this functionality on this device.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>  Documentation/devicetree/bindings/mfd/as3722.txt |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index fc2191e..1e54937 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -112,6 +112,15 @@ Following are properties of regulator subnode.
>  		ams,enable-tracking: Enable tracking with SD1, only supported
>  			by LDO3.
>  
> +Power-off:
> +=========
> +AS3722 supports the system power off by turning off all its rail. The power off
> +is provided through pm power off.

I think pm_power_off is a Linuxisum.

> +The device node should have the following properties to enable power-off

Why is it power-off here and power off everywhere else?

> +functionality from ams AS3722:
> +ams,system-power-controller: To enable the power off functionality through
> +	device.

Do what with it? "on", "<1>", something else?

>  Example:
>  --------
>  #include <dt-bindings/mfd/as3722.h>

Should it be represented in the example?
Stephen Warren Dec. 19, 2013, 7:03 p.m. UTC | #2
On 12/19/2013 06:06 AM, Lee Jones wrote:
> On Thu, 19 Dec 2013, Laxman Dewangan wrote:
> 
>> ams AS3722 device supports the power off by turning off its all rails.
>>
>> Add dt node properties to enable this functionality on this device.

>> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt

>> +functionality from ams AS3722:
>> +ams,system-power-controller: To enable the power off functionality through
>> +	device.
> 
> Do what with it? "on", "<1>", something else?

It's a Boolean property, so just add the name to the DT, no value.
Admittedly the binding should state this.

The series,

Tested-by: Stephen Warren <swarren@nvidia.com>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones Dec. 20, 2013, 1:47 p.m. UTC | #3
> >> ams AS3722 device supports the power off by turning off its all rails.
> >>
> >> Add dt node properties to enable this functionality on this device.
> 
> >> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> 
> >> +functionality from ams AS3722:
> >> +ams,system-power-controller: To enable the power off functionality through
> >> +	device.
> > 
> > Do what with it? "on", "<1>", something else?
> 
> It's a Boolean property, so just add the name to the DT, no value.
> Admittedly the binding should state this.

I was being pedantic. ;)

> The series,
> 
> Tested-by: Stephen Warren <swarren@nvidia.com>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
index fc2191e..1e54937 100644
--- a/Documentation/devicetree/bindings/mfd/as3722.txt
+++ b/Documentation/devicetree/bindings/mfd/as3722.txt
@@ -112,6 +112,15 @@  Following are properties of regulator subnode.
 		ams,enable-tracking: Enable tracking with SD1, only supported
 			by LDO3.
 
+Power-off:
+=========
+AS3722 supports the system power off by turning off all its rail. The power off
+is provided through pm power off.
+The device node should have the following properties to enable power-off
+functionality from ams AS3722:
+ams,system-power-controller: To enable the power off functionality through
+	device.
+
 Example:
 --------
 #include <dt-bindings/mfd/as3722.h>