Patchwork [sata_fsl] Defer non-ncq commands when ncq commands active

login
register
mail settings
Submitter Kalra Ashish-B00888
Date July 29, 2009, 4:03 p.m.
Message ID <Pine.WNT.4.64.0907292129310.4440@B00888-02.fsl.freescale.net>
Download mbox | patch
Permalink /patch/30349/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Kalra Ashish-B00888 - July 29, 2009, 4:03 p.m.
From: Ashish Kalra <Ashish.Kalra@freescale.com>
Date: Wed, 29 Jul 2009 21:15:49 +0530

Fix for non-ncq & ncq commands causing timeouts when both are issued 
simultaneously to the same device.

Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
---
  drivers/ata/sata_fsl.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Robert Hancock - July 29, 2009, 7:48 p.m.
On 07/29/2009 10:03 AM, ashish kalra wrote:
> From: Ashish Kalra <Ashish.Kalra@freescale.com>
> Date: Wed, 29 Jul 2009 21:15:49 +0530
>
> Fix for non-ncq & ncq commands causing timeouts when both are issued
> simultaneously to the same device.
>
> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> ---
> drivers/ata/sata_fsl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 5a88b44..a33f130 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
> static struct ata_port_operations sata_fsl_ops = {
> .inherits = &sata_pmp_port_ops,
>
> + .qc_defer = ata_std_qc_defer;
> .qc_prep = sata_fsl_qc_prep,
> .qc_issue = sata_fsl_qc_issue,
> .qc_fill_rtf = sata_fsl_qc_fill_rtf,

This doesn't look like it should change anything. sata_fsl_ops inherits 
from sata_pmp_port_ops, which inherits from sata_port_ops, which already 
sets qc_defer to ata_std_qc_defer.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kumar Gala - July 30, 2009, 1:43 p.m.
On Jul 30, 2009, at 8:23 AM, Kalra Ashish-B00888 wrote:

> Hello,
>
> >> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> >> ---
> >> drivers/ata/sata_fsl.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> >> index 5a88b44..a33f130 100644
> >> --- a/drivers/ata/sata_fsl.c
> >> +++ b/drivers/ata/sata_fsl.c
> >> @@ -1262,6 +1262,7 @@ static struct scsi_host_template  
> sata_fsl_sht = {
> >> static struct ata_port_operations sata_fsl_ops = {
> >> .inherits = &sata_pmp_port_ops,
> >>
> >> + .qc_defer = ata_std_qc_defer;
> >> .qc_prep = sata_fsl_qc_prep,
> >> .qc_issue = sata_fsl_qc_issue,
> >> .qc_fill_rtf = sata_fsl_qc_fill_rtf,
>
> > This doesn't look like it should change anything. sata_fsl_ops  
> inherits
> > from sata_pmp_port_ops, which inherits from sata_port_ops, which  
> already
> > sets qc_defer to ata_std_qc_defer.
> Oh, yes. Actually this patch was for older kernels where there  
> inheritence was not there. As you mentioned, this patch is not  
> required now.
>
How old?  Should we be asking for this to be applied to some of the  
stable kernel series?

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kumar Gala - July 30, 2009, 2:02 p.m.
On Jul 30, 2009, at 8:58 AM, Kalra Ashish-B00888 wrote:

> Hello Kumar,
>
> >> > This doesn't look like it should change anything. sata_fsl_ops
> >> inherits
> >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which
> >> already
> >> > sets qc_defer to ata_std_qc_defer.
> >> Oh, yes. Actually this patch was for older kernels where there
> >> inheritence was not there. As you mentioned, this patch is not
> >> required now.
> >>
> >How old?  Should we be asking for this to be applied to some of the
> >stable kernel series?
>
> I believe that the inheritence stuff was added in 2.6.26, thus, this  
> patch is
> required for quite old kernels ( < 2.6.26 ).

Ok, than I'm not going to worry about it.

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Sept. 9, 2009, 1:25 a.m.
On 07/29/2009 12:03 PM, ashish kalra wrote:
> From: Ashish Kalra <Ashish.Kalra@freescale.com>
> Date: Wed, 29 Jul 2009 21:15:49 +0530
>
> Fix for non-ncq & ncq commands causing timeouts when both are issued
> simultaneously to the same device.
>
> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com>
> ---
> drivers/ata/sata_fsl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 5a88b44..a33f130 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
> static struct ata_port_operations sata_fsl_ops = {
> .inherits = &sata_pmp_port_ops,
>
> + .qc_defer = ata_std_qc_defer;

Applied version with obvious s/;/,/ fix...

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 5a88b44..a33f130 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1262,6 +1262,7 @@  static struct scsi_host_template sata_fsl_sht = {
  static struct ata_port_operations sata_fsl_ops = {
  	.inherits		= &sata_pmp_port_ops,

+	.qc_defer = ata_std_qc_defer;
  	.qc_prep = sata_fsl_qc_prep,
  	.qc_issue = sata_fsl_qc_issue,
  	.qc_fill_rtf = sata_fsl_qc_fill_rtf,