From patchwork Tue Jul 28 18:25:19 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Phadke X-Patchwork-Id: 30315 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id D9DA6B7B6D for ; Wed, 29 Jul 2009 04:28:31 +1000 (EST) Received: by ozlabs.org (Postfix) id CAD15DDD04; Wed, 29 Jul 2009 04:28:31 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 52A55DDD01 for ; Wed, 29 Jul 2009 04:28:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755461AbZG1S2P (ORCPT ); Tue, 28 Jul 2009 14:28:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755450AbZG1S2N (ORCPT ); Tue, 28 Jul 2009 14:28:13 -0400 Received: from avexch1.qlogic.com ([198.70.193.115]:42778 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390AbZG1S2L convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2009 14:28:11 -0400 Received: from avexcashub1.qlogic.org ([10.1.4.112]) by avexch1.qlogic.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 28 Jul 2009 11:28:05 -0700 Received: from avexcashub2.qlogic.org (10.1.4.116) by avexcashub1.qlogic.org (10.1.4.161) with Microsoft SMTP Server (TLS) id 8.1.375.2; Tue, 28 Jul 2009 11:28:04 -0700 Received: from avexmb1.qlogic.org ([fe80::9526:ffe6:33fc:cbe3]) by avexcashub2.qlogic.org ([::1]) with mapi; Tue, 28 Jul 2009 11:28:05 -0700 From: Dhananjay Phadke To: Randy Dunlap , Stephen Rothwell , "davem@davemloft.net" CC: "linux-next@vger.kernel.org" , LKML , netdev Date: Tue, 28 Jul 2009 11:25:19 -0700 Subject: RE: [PATCH -next] netxen: fix build when CONFIG_INET=n Thread-Topic: [PATCH -next] netxen: fix build when CONFIG_INET=n Thread-Index: AcoPsDrHBwFeH1ghTRyZCO98gWP9iAAAIf1c Message-ID: <7608421F3572AB4292BB2532AE89D5658187610C1C@AVEXMB1.qlogic.org> References: <20090728174224.647cc3ba.sfr@canb.auug.org.au>, <20090728112103.81f229d6.randy.dunlap@oracle.com> In-Reply-To: <20090728112103.81f229d6.randy.dunlap@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginalArrivalTime: 28 Jul 2009 18:28:05.0073 (UTC) FILETIME=[25C44C10:01CA0FB1] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thanks Randy for catching, I didn't run CONFIG_INET=n build. I think, better option is to wrap code in netxen_nic_main.c with CONFIG_INET check, since it's not a mandatory feature. -Dhananjay --- linux-next-20090728.orig/drivers/net/Kconfig +++ linux-next-20090728/drivers/net/Kconfig @@ -2666,7 +2666,7 @@ config MYRI10GE_DCA config NETXEN_NIC tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" - depends on PCI + depends on PCI && INET help This enables the support for NetXen's Gigabit Ethernet card.