Patchwork [v5] KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state

login
register
mail settings
Submitter Alexander Graf
Date Dec. 18, 2013, 10:05 p.m.
Message ID <D78CEEE8-20B4-4088-8050-DB5D7B7D9C72@suse.de>
Download mbox | patch
Permalink /patch/303099/
State New
Headers show

Comments

Alexander Graf - Dec. 18, 2013, 10:05 p.m.
On 29.11.2013, at 03:01, “tiejun.chen” <tiejun.chen@windriver.com> wrote:

> Alex,
> 
> I suppose Scott already elaborate anything you want to know.

Thanks, applied with this minor patch on top:


I've also taken the liberty of making the patch description be more verbose:

KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state

Rather than calling hard_irq_disable() when we're back in C code
we can just call RECONCILE_IRQ_STATE to soft disable IRQs while
we're already in hard disabled state.

This should be functionally equivalent to the code before, but
cleaner and faster.

Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
[agraf: fix comment, commit message]
Signed-off-by: Alexander Graf <agraf@suse.de>


Thanks, applied to kvm-ppc-queue.

Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
index 191c32b..be3de1d 100644
--- a/arch/powerpc/kvm/bookehv_interrupts.S
+++ b/arch/powerpc/kvm/bookehv_interrupts.S
@@ -470,7 +470,7 @@  _GLOBAL(kvmppc_resume_host)
 #ifdef CONFIG_64BIT
        /*
         * We enter with interrupts disabled in hardware, but
-        * we need to call RECONCILE_IRQ_STATE anyway to ensure
+        * we need to call RECONCILE_IRQ_STATE to ensure
         * that the software state is kept in sync.
         */
        RECONCILE_IRQ_STATE(r3,r5)