diff mbox

[U-Boot,v2,04/13] samsung: common: Add misc file and common function misc_init_r().

Message ID 3ca52dfb01a883c344b7789e096831974df5a6d0.1387390491.git.p.marczak@samsung.com
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Przemyslaw Marczak Dec. 18, 2013, 6:31 p.m. UTC 
Config: CONFIG_MISC_INIT_R enables implementation of misc_init_r()
in common file::
- board/samsung/common/misc.c

Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>

---
Changes v2:
- change CONFIG_SAMSUNG to CONFIG_MISC_INIT_R
---
 board/samsung/common/Makefile |    1 +
 board/samsung/common/misc.c   |   14 ++++++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 board/samsung/common/misc.c

Comments

Minkyu Kang Jan. 2, 2014, 6:37 a.m. UTC | #1 
On 19/12/13 03:31, Przemyslaw Marczak wrote:
> Config: CONFIG_MISC_INIT_R enables implementation of misc_init_r()
> in common file::
> - board/samsung/common/misc.c

I can't understand this commit message.
What means?

> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> 
> ---
> Changes v2:
> - change CONFIG_SAMSUNG to CONFIG_MISC_INIT_R
> ---
>  board/samsung/common/Makefile |    1 +
>  board/samsung/common/misc.c   |   14 ++++++++++++++
>  2 files changed, 15 insertions(+)
>  create mode 100644 board/samsung/common/misc.c
> 
> diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
> index 501d974..c30bb3d 100644
> --- a/board/samsung/common/Makefile
> +++ b/board/samsung/common/Makefile
> @@ -8,3 +8,4 @@
>  obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
>  obj-$(CONFIG_THOR_FUNCTION) += thor.o
>  obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
> +obj-$(CONFIG_MISC_INIT_R) += misc.o
> diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
> new file mode 100644
> index 0000000..3764d12
> --- /dev/null
> +++ b/board/samsung/common/misc.c
> @@ -0,0 +1,14 @@
> +/*
> + * Copyright (C) 2013 Samsung Electronics
> + * Przemyslaw Marczak <p.marczak@samsung.com>
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#include <common.h>
> +
> +/* Common for Samsung boards */
> +int misc_init_r(void)
> +{
> +	return 0;
> +}
>
Przemyslaw Marczak Jan. 2, 2014, 8:09 a.m. UTC | #2 
Hello Minkyu,

On 01/02/2014 07:37 AM, Minkyu Kang wrote:
> On 19/12/13 03:31, Przemyslaw Marczak wrote:
>> Config: CONFIG_MISC_INIT_R enables implementation of misc_init_r()
>> in common file::
>> - board/samsung/common/misc.c
>
> I can't understand this commit message.
> What means?
>

I mean that implementation of function misc_init_r() in file 
board/samsung/common/misc.c can be enabled just by adding this config 
(CONFIG_MISC_INIT_R) for Samsung devices.

Regards
diff mbox

Patch

diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
index 501d974..c30bb3d 100644
--- a/board/samsung/common/Makefile
+++ b/board/samsung/common/Makefile
@@ -8,3 +8,4 @@ 
 obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
 obj-$(CONFIG_THOR_FUNCTION) += thor.o
 obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
+obj-$(CONFIG_MISC_INIT_R) += misc.o
diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
new file mode 100644
index 0000000..3764d12
--- /dev/null
+++ b/board/samsung/common/misc.c
@@ -0,0 +1,14 @@ 
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ * Przemyslaw Marczak <p.marczak@samsung.com>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <common.h>
+
+/* Common for Samsung boards */
+int misc_init_r(void)
+{
+	return 0;
+}