diff mbox

[09/15] net: ixgbe calls skb_set_hash

Message ID alpine.DEB.2.02.1312172324380.24772@tomh.mtv.corp.google.com
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show

Commit Message

Tom Herbert Dec. 18, 2013, 7:28 a.m. UTC
Drivers should call skb_set_hash to set the hash and its type
in an skbuff.

Signed-off-by: Tom Herbert <therbert@google.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Kirsher, Jeffrey T Dec. 18, 2013, 8:41 a.m. UTC | #1
On Tue, Dec 17, 2013 at 11:28 PM, Tom Herbert <therbert@google.com> wrote:
> Drivers should call skb_set_hash to set the hash and its type
> in an skbuff.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

I have added this patch to my queue, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Brown, Aaron F Jan. 14, 2014, 2:26 a.m. UTC | #2
On Wed, 2013-12-18 at 00:41 -0800, Jeff Kirsher wrote:
> On Tue, Dec 17, 2013 at 11:28 PM, Tom Herbert <therbert@google.com> wrote:
> > Drivers should call skb_set_hash to set the hash and its type
> > in an skbuff.
> >
> > Signed-off-by: Tom Herbert <therbert@google.com>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> 
> I have added this patch to my queue, thanks Tom.

Signed-off by: Aaron Brown <aaron.f.brown@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index cc06854..cbe5f3d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -1233,7 +1233,9 @@  static inline void ixgbe_rx_hash(struct ixgbe_ring *ring,
 				 struct sk_buff *skb)
 {
 	if (ring->netdev->features & NETIF_F_RXHASH)
-		skb->rxhash = le32_to_cpu(rx_desc->wb.lower.hi_dword.rss);
+		skb_set_hash(skb,
+			     le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),
+			     PKT_HASH_TYPE_L3);
 }
 
 #ifdef IXGBE_FCOE