| Message ID | alpine.DEB.2.02.1312172325550.24389@tomh.mtv.corp.google.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Dec 17, 2013 at 11:27 PM, Tom Herbert <therbert@google.com> wrote: > Drivers should call skb_set_hash to set the hash and its type > in an skbuff. > > Signed-off-by: Tom Herbert <therbert@google.com> > --- > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > I have added this patch to my queue, thanks Tom. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Jeff Kirsher > Sent: Wednesday, December 18, 2013 12:40 AM > To: Tom Herbert > Cc: David Miller; netdev > Subject: Re: [PATCH 07/15] net: i40e calls skb_set_hash > > On Tue, Dec 17, 2013 at 11:27 PM, Tom Herbert <therbert@google.com> wrote: > > Drivers should call skb_set_hash to set the hash and its type in an > > skbuff. > > > > Signed-off-by: Tom Herbert <therbert@google.com> > > --- > > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > I have added this patch to my queue, thanks Tom. And unfortunately it fails to compile giving the following error: ------------------------------------------------------------------------ drivers/net/ethernet/intel/i40e/i40e_txrx.c: In function 'i40e_clean_rx_irq': drivers/net/ethernet/intel/i40e/i40e_txrx.c:1088: error: too few arguments to function 'i40e_rx_checksum'
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index 01d0334..2447d1c 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c @@ -1031,7 +1031,8 @@ static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget) goto next_desc; } - skb->rxhash = i40e_rx_hash(rx_ring, rx_desc); + skb_set_hash(skb, i40e_rx_hash(rx_ring, rx_desc), + PKT_HASH_TYPE_L3); i40e_rx_checksum(vsi, skb, rx_status, rx_error); /* probably a little skewed due to removing CRC */
Drivers should call skb_set_hash to set the hash and its type in an skbuff. Signed-off-by: Tom Herbert <therbert@google.com> --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)