Patchwork [2/2] drivers: ide: Include appropriate header file in ide-pio-blacklist.c

login
register
mail settings
Submitter Rashika Kheria
Date Dec. 17, 2013, 11:11 a.m.
Message ID <2ec755ae03ae9f912f40a12a241f997909f380a1.1387278225.git.rashika.kheria@gmail.com>
Download mbox | patch
Permalink /patch/302091/
State Accepted
Delegated to: David Miller
Headers show

Comments

Rashika Kheria - Dec. 17, 2013, 11:11 a.m.
Include appropriate header file include/linux/ide.h in file
ide-pio-blacklist.c because function ide_scan_pio_blacklist() has it's
prototype declaration in include/linux/ide.h.

This eliminates the following warning in ide-pio-blacklist.c:
drivers/ide/ide-pio-blacklist.c:85:5: warning: no previous prototype for ‘ide_scan_pio_blacklist’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/ide/ide-pio-blacklist.c |    1 +
 1 file changed, 1 insertion(+)
Josh Triplett - Dec. 17, 2013, 4:37 p.m.
On Tue, Dec 17, 2013 at 04:41:11PM +0530, Rashika Kheria wrote:
> Include appropriate header file include/linux/ide.h in file
> ide-pio-blacklist.c because function ide_scan_pio_blacklist() has it's
> prototype declaration in include/linux/ide.h.
> 
> This eliminates the following warning in ide-pio-blacklist.c:
> drivers/ide/ide-pio-blacklist.c:85:5: warning: no previous prototype for ‘ide_scan_pio_blacklist’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/ide/ide-pio-blacklist.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ide/ide-pio-blacklist.c b/drivers/ide/ide-pio-blacklist.c
> index a8c2c8f8..40e683a 100644
> --- a/drivers/ide/ide-pio-blacklist.c
> +++ b/drivers/ide/ide-pio-blacklist.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/string.h>
> +#include <linux/ide.h>
>  
>  static struct ide_pio_info {
>  	const char	*name;
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Jan. 29, 2014, 7:37 a.m.
From: Rashika Kheria <rashika.kheria@gmail.com>

Date: Tue, 17 Dec 2013 16:41:11 +0530

> Include appropriate header file include/linux/ide.h in file

> ide-pio-blacklist.c because function ide_scan_pio_blacklist() has it's

> prototype declaration in include/linux/ide.h.

> 

> This eliminates the following warning in ide-pio-blacklist.c:

> drivers/ide/ide-pio-blacklist.c:85:5: warning: no previous prototype for ‘ide_scan_pio_blacklist’ [-Wmissing-prototypes]

> 

> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>


Applied.

Patch

diff --git a/drivers/ide/ide-pio-blacklist.c b/drivers/ide/ide-pio-blacklist.c
index a8c2c8f8..40e683a 100644
--- a/drivers/ide/ide-pio-blacklist.c
+++ b/drivers/ide/ide-pio-blacklist.c
@@ -7,6 +7,7 @@ 
  */
 
 #include <linux/string.h>
+#include <linux/ide.h>
 
 static struct ide_pio_info {
 	const char	*name;