Patchwork [Hostapd] NEED_AP_MLME for hostapd when MLME is in firmware

login
register
mail settings
Submitter dhanajit.roy@wipro.com
Date Dec. 17, 2013, 4:48 a.m.
Message ID <4B593B70622AB44FA0EFB5A9156A95EB7513522D@CHN-SNR-MBX-2.wipro.com>
Download mbox | patch
Permalink /patch/301992/
State New
Headers show

Comments

dhanajit.roy@wipro.com - Dec. 17, 2013, 4:48 a.m.
Hi,

I am working on a project , where WLAN is a full mac device.  I need to enable softap .
MLME for access point mode gets handled inside firmware . In that case , do I need to disable NEED_AP_MLME in Hostapd build configuration . 
But it seems by default NEED_AP_MLME is enabled with driver_nl80211. 

Will it be correct to disable the NEED_AP_MLME or any other alternative is available . Please suggest.

I am looking at wpa_supplicant version '2.0-devel' codebase ( Android Jellybean 4.3 AOSP).

Regards
Dhanajit


-----Original Message-----
From: hostap-bounces@lists.shmoo.com [mailto:hostap-bounces@lists.shmoo.com] On Behalf Of hostap-request@lists.shmoo.com
Sent: 13 December 2013 22:30
To: hostap@lists.shmoo.com
Subject: HostAP Digest, Vol 128, Issue 12

Send HostAP mailing list submissions to
	hostap@lists.shmoo.com

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.shmoo.com/mailman/listinfo/hostap
or, via email, send a message with subject or body 'help' to
	hostap-request@lists.shmoo.com

You can reach the person managing the list at
	hostap-owner@lists.shmoo.com

When replying, please edit your Subject line so it is more specific than "Re: Contents of HostAP digest..."


Today's Topics:

   1. [Patch] IEEE80211R: Support FT-OVER-DS when use driver as SME
      (Zhiyuan Yang)
   2. [PATCH] hostapd: Clean interface_added flag (Marek Kwaczynski)
   3. Re: Linux wifi monitor interface type for A20/BCM4329/BCM4330
      (Arend van Spriel)
   4. Re: Linux wifi monitor interface type for A20/BCM4329/BCM4330
      (Arend van Spriel)


----------------------------------------------------------------------

Message: 1
Date: Thu, 12 Dec 2013 23:40:48 -0800
From: Zhiyuan Yang <yangzy@marvell.com>
Subject: [Patch] IEEE80211R: Support FT-OVER-DS when use driver as SME
To: "hostap@lists.shmoo.com" <hostap@lists.shmoo.com>, "j@w1.fi"
	<j@w1.fi>
Cc: Kevin Gan <ganhy@marvell.com>, Cathy Luo <cluo@marvell.com>,
	Tristan Xu <xurf@marvell.com>
Message-ID:
	<23E65EE4544D484CBE73B588E192C6D620B538C878@sc-vexch3.marvell.com>
Content-Type: text/plain; charset="us-ascii"

Hi,

This patch is to support IEEE80211R FT-OVER-DS when use driver as SME.
When use command FT_DS <MAC Adress>, FT action will be refused when not use wpa supplicant as SME.
As follow:
         if (!(wpa_s->drv_flags & WPA_DRIVER_FLAGS_SME))
                   return; /* only SME case supported for now */ Delete this check, and add some other changes to support ft-over-ds when use driver as SME.
This changes will not affect ft-over-ds when use WPA supplicant as SME.

Thanks
BR
zhiyuan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.shmoo.com/pipermail/hostap/attachments/20131212/1082a68d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-IEEE80211R-support-ft-over-ds-when-use-driver-as-sme.patch
Type: application/octet-stream
Size: 2067 bytes
Desc: 0001-IEEE80211R-support-ft-over-ds-when-use-driver-as-sme.patch
URL: <http://lists.shmoo.com/pipermail/hostap/attachments/20131212/1082a68d/attachment-0001.obj>

------------------------------

Message: 2
Date: Fri, 13 Dec 2013 10:32:36 +0100
From: Marek Kwaczynski <marek.kwaczynski@tieto.com>
Subject: [PATCH] hostapd: Clean interface_added flag
To: hostap@lists.shmoo.com
Cc: j@w1.fi
Message-ID:
	<1386927156-3973-1-git-send-email-marek.kwaczynski@tieto.com>

If more BSS networks are added in config file than are supported by the driver, segmantation fault can appear.
For this case clean interface_added flag is needed when adding new BSS failed.

Signed-hostap: Marek Kwaczynski <marek.kwaczynski@tieto.com>
---

Without this fix I saw segmantation fault or
"wlan0: Could not connect to kernel driver" in hostapd when I added more BSS networks in config file than are supported by the driver. For example when I created the following BSSs in config file:
1) wlan0
2) wlan0-1
3) wlan0-2
4) wlan0-3

and the last one couldn't be added because it wasn't supported by the driver, I received the following debug print:

nl80211: Adding interface wlan0-3 into bridge br-lan Could not set interface wlan0-3 flags (UP): Device or resource busy

After that when I killed hostapd, it tried to remove wlan0-3 and delete global bss pointer - wlan0


 src/ap/hostapd.c |    1 +
 1 file changed, 1 insertion(+)

--
1.7.9.5



------------------------------

Message: 3
Date: Fri, 13 Dec 2013 14:08:32 +0100
From: Arend van Spriel <arend@broadcom.com>
Subject: Re: Linux wifi monitor interface type for A20/BCM4329/BCM4330
To: Axel Christiansen <axel@hardreset.de>,
	<brcm80211-dev-list@broadcom.com>, 	"hostap@lists.shmoo.com"
	<hostap@lists.shmoo.com>
Message-ID: <52AB06D0.2020906@broadcom.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed

+ hostap list

On 12/13/2013 02:04 PM, Axel Christiansen wrote:
> Am 13.12.2013 13:22:50, schrieb Arend van Spriel:
>
>     On 12/13/2013 12:51 PM, Axel Christiansen wrote:
>
>         Hello dear Developer.
>
>
>         Hopefully this mail is getting through.
>
>         I was wondering if one can tell me about the support f?r
>         interface type
>         monitor for:
>
>         driver brcmfmac, os linux, arch arm, hardware BCM4329 or BCM4330
>
>         Does it work?
>         When is it expected to work?
>
>
>         I got one of those really nice cubieboards/A20 SBC with
>         integrated wifi
>         and sadly without monitor interface WPA-encyption as
>         access-point will
>         not work.
>
>
>     what kernel version are you using? brcmfmac does not need monitor
>     interface for AP operation.
>
>     Gr. AvS
>
>
>
> AP Mode works fine. I belief for encryption especially WPA/WPA2 on Linux
> the hostap daemon is widely used. hostapd itself needs that monitor
> interface, if i am not too much mistaken.

If I am not mistaken you need either monitor interface or support for 
mgmt_rx. brcmfmac has mgmt_rx support.

Regards,
Arend

> Kernel 3.4
>
>
> thx, Axel
>
>
>
>
>
>



------------------------------

Message: 4
Date: Fri, 13 Dec 2013 15:44:59 +0100
From: Arend van Spriel <arend@broadcom.com>
Subject: Re: Linux wifi monitor interface type for A20/BCM4329/BCM4330
To: Axel Christiansen <axel@hardreset.de>,
	<brcm80211-dev-list@broadcom.com>, 	<hostap@lists.shmoo.com>
Message-ID: <52AB1D6B.1030205@broadcom.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed

On 12/13/2013 02:33 PM, Axel Christiansen wrote:
> Am 13.12.2013 14:08:32, schrieb Arend van Spriel:
>
>     + hostap list
>
>     On 12/13/2013 02:04 PM, Axel Christiansen wrote:
>
>         Am 13.12.2013 13:22:50, schrieb Arend van Spriel:
>
>         On 12/13/2013 12:51 PM, Axel Christiansen wrote:
>
>         Hello dear Developer.
>
>
>         Hopefully this mail is getting through.
>
>         I was wondering if one can tell me about the support f?r
>         interface type
>         monitor for:
>
>         driver brcmfmac, os linux, arch arm, hardware BCM4329 or BCM4330
>
>         Does it work?
>         When is it expected to work?
>
>
>         I got one of those really nice cubieboards/A20 SBC with
>         integrated wifi
>         and sadly without monitor interface WPA-encyption as
>         access-point will
>         not work.
>
>
>         what kernel version are you using? brcmfmac does not need monitor
>         interface for AP operation.
>
>         Gr. AvS
>
>
>
>         AP Mode works fine. I belief for encryption especially WPA/WPA2
>         on Linux
>         the hostap daemon is widely used. hostapd itself needs that monitor
>         interface, if i am not too much mistaken.
>
>
>     If I am not mistaken you need either monitor interface or support for
>     mgmt_rx. brcmfmac has mgmt_rx support.
>
>     Regards,
>     Arend
>
>
>
> That sound promising. Thx a lot.

The bad news is the kernel version. I think 3.4 will give some issues 
using brcmfmac in AP mode.

Regards,
Arend

>
>
> Regards. Axel
>
>
>
>



------------------------------

Patch

diff --git a/src/ap/hostapd.c b/src/ap/hostapd.c index 6fe2956..a436c2a 100644
--- a/src/ap/hostapd.c
+++ b/src/ap/hostapd.c
@@ -667,6 +667,7 @@  static int hostapd_setup_bss(struct hostapd_data *hapd, int first)
 				   NULL, first == -1)) {
 			wpa_printf(MSG_ERROR, "Failed to add BSS (BSSID="
 				   MACSTR ")", MAC2STR(hapd->own_addr));
+			hapd->interface_added = 0;
 			return -1;
 		}
 	}