Patchwork powerpc: minor Makefile simplification through use of cc-ifversion

login
register
mail settings
Submitter Frans Pop
Date July 23, 2009, 6:57 p.m.
Message ID <200907232057.19942.elendil@planet.nl>
Download mbox | patch
Permalink /patch/30148/
State Accepted, archived
Commit f7d4f68d971b8234491b4a0be58aa6f659c1c194
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Frans Pop - July 23, 2009, 6:57 p.m.
Signed-off-by: Frans Pop <elendil@planet.nl>
---

Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
Untested.
Sam Ravnborg - July 23, 2009, 9:31 p.m.
On Thu, Jul 23, 2009 at 08:57:18PM +0200, Frans Pop wrote:
> Signed-off-by: Frans Pop <elendil@planet.nl>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Benjamin Herrenschmidt - July 23, 2009, 11:52 p.m.
On Thu, 2009-07-23 at 23:31 +0200, Sam Ravnborg wrote:
> On Thu, Jul 23, 2009 at 08:57:18PM +0200, Frans Pop wrote:
> > Signed-off-by: Frans Pop <elendil@planet.nl>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Thanks, will include in my next batch.

Cheers,
Ben.

Patch

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index bc35f4e..952a396 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -77,7 +77,7 @@  CPP		= $(CC) -E $(KBUILD_CFLAGS)
 CHECKFLAGS	+= -m$(CONFIG_WORD_SIZE) -D__powerpc__ -D__powerpc$(CONFIG_WORD_SIZE)__
 
 ifeq ($(CONFIG_PPC64),y)
-GCC_BROKEN_VEC	:= $(shell if [ $(call cc-version) -lt 0400 ] ; then echo "y"; fi)
+GCC_BROKEN_VEC	:= $(call cc-ifversion, -lt, 0400, y)
 
 ifeq ($(CONFIG_POWER4_ONLY),y)
 ifeq ($(CONFIG_ALTIVEC),y)