Patchwork [net-next] bnad: make local variable static

login
register
mail settings
Submitter stephen hemminger
Date Dec. 14, 2013, 12:40 a.m.
Message ID <20131213164010.0d082bbe@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/301190/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Dec. 14, 2013, 12:40 a.m.
Compile tested only.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rasesh Mody - Dec. 14, 2013, 1:34 a.m.
>From: Stephen Hemminger [mailto:stephen@networkplumber.org]
>Sent: Friday, December 13, 2013 4:40 PM
>
>Compile tested only.

Thanks Stephen!

Sanity and basic traffic test conducted and it looks fine.

Acked-by: Rasesh Mody <rmody@brocade.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 17, 2013, 8:19 p.m.
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 13 Dec 2013 16:40:10 -0800

> Compile tested only.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/net/ethernet/brocade/bna/bnad.c	2013-12-12 11:48:17.033855594 -0800
+++ b/drivers/net/ethernet/brocade/bna/bnad.c	2013-12-12 11:56:57.325752730 -0800
@@ -52,7 +52,7 @@  MODULE_PARM_DESC(bna_debugfs_enable, "En
 /*
  * Global variables
  */
-u32 bnad_rxqs_per_cq = 2;
+static u32 bnad_rxqs_per_cq = 2;
 static u32 bna_id;
 static struct mutex bnad_list_mutex;
 static LIST_HEAD(bnad_list);
--- a/drivers/net/ethernet/brocade/bna/bnad.h	2013-12-12 11:48:17.033855594 -0800
+++ b/drivers/net/ethernet/brocade/bna/bnad.h	2013-12-12 11:56:57.325752730 -0800
@@ -367,7 +367,6 @@  struct bnad_drvinfo {
  * EXTERN VARIABLES
  */
 extern const struct firmware *bfi_fw;
-extern u32		bnad_rxqs_per_cq;
 
 /*
  * EXTERN PROTOTYPES