Patchwork [1/4] net: phy: call put_device on device_register() failure

login
register
mail settings
Submitter Levente Kurusa
Date Dec. 13, 2013, 7:22 p.m.
Message ID <1386962557-8899-2-git-send-email-levex@linux.com>
Download mbox | patch
Permalink /patch/301158/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Levente Kurusa - Dec. 13, 2013, 7:22 p.m.
It is required to call put_device() if device_register() fails,
so that we give up the last reference to the device. Calling put_device
allows for mdiobus_release to be executed, kfreeing the bus.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Levente Kurusa <levex@linux.com>
---
 drivers/net/phy/mdio_bus.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 5617876..b071af7 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -154,6 +154,7 @@  int mdiobus_register(struct mii_bus *bus)
 	err = device_register(&bus->dev);
 	if (err) {
 		pr_err("mii_bus %s failed to register\n", bus->id);
+		put_device(&bus->dev);
 		return -EINVAL;
 	}