Patchwork sky2: remove unnecessary assignment

login
register
mail settings
Submitter Mike McCormack
Date July 23, 2009, 2:53 a.m.
Message ID <392fb48f0907221953j77b8ea0etcad115f9b2c99c7b@mail.gmail.com>
Download mbox | patch
Permalink /patch/30104/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Mike McCormack - July 23, 2009, 2:53 a.m.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
---
 drivers/net/sky2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - July 23, 2009, 4:04 a.m.
From: Mike McCormack <mikem@ring3k.org>
Date: Thu, 23 Jul 2009 11:53:58 +0900

> Signed-off-by: Mike McCormack <mikem@ring3k.org>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>

When people ACK your patches and they are still in
"Under Review" state in patchwork, you DO NOT have
to resend the patch.

When I grab it out of patchwork and apply it to my
tree patchwork has seen all of the Acked-by and other
tags in the replies and puts it into the commit
message for me.

By resending this you're making MORE work for me, not
LESS.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 3550c5d..661abd0 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -4117,7 +4117,7 @@  static int sky2_debug_show(struct seq_file *seq, void *v)

 	seq_printf(seq, "\nRx ring hw get=%d put=%d last=%d\n",
 		   sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_GET_IDX)),
-		   last = sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
+		   sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_PUT_IDX)),
 		   sky2_read16(hw, Y2_QADDR(rxqaddr[port], PREF_UNIT_LAST_IDX)));

 	sky2_read32(hw, B0_Y2_SP_LISR);