Message ID | 1386943124-8005-1-git-send-email-ezequiel.garcia@free-electrons.com |
---|---|
State | Superseded |
Headers | show |
On Fri, Dec 13, 2013 at 10:58:44AM -0300, Ezequiel Garcia wrote: > Make this option a hidden one and get a cleaner configuration. > This option just selects a common infrastructure for MTD-based devices > to expose a block interface. There is no point in allowing a separate > enable/disable. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > drivers/mtd/Kconfig | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > index 5fab4e6e..2a0ca2a 100644 > --- a/drivers/mtd/Kconfig > +++ b/drivers/mtd/Kconfig > @@ -158,9 +158,7 @@ config MTD_BCM47XX_PARTS > comment "User Modules And Translation Layers" > > config MTD_BLKDEVS > - tristate "Common interface to block layer for MTD 'translation layers'" > - depends on BLOCK > - default n > + bool > > config MTD_BLOCK > tristate "Caching block device access to MTD devices" > -- > 1.8.1.5 > Any comments on this one?
On Thu, Dec 19, 2013 at 09:47:13PM -0300, Ezequiel Garcia wrote: > On Fri, Dec 13, 2013 at 10:58:44AM -0300, Ezequiel Garcia wrote: > > Make this option a hidden one and get a cleaner configuration. > > This option just selects a common infrastructure for MTD-based devices > > to expose a block interface. There is no point in allowing a separate > > enable/disable. > > > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > > --- > > drivers/mtd/Kconfig | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > > index 5fab4e6e..2a0ca2a 100644 > > --- a/drivers/mtd/Kconfig > > +++ b/drivers/mtd/Kconfig > > @@ -158,9 +158,7 @@ config MTD_BCM47XX_PARTS > > comment "User Modules And Translation Layers" > > > > config MTD_BLKDEVS > > - tristate "Common interface to block layer for MTD 'translation layers'" > > - depends on BLOCK > > - default n > > + bool > > > > config MTD_BLOCK > > tristate "Caching block device access to MTD devices" > > Any comments on this one? It looks OK to me. I might add a comment above MTD_BLKDEVS like I see in some other similar Kconfig not-user-selectable options: # # MTD block device support is select'ed if needed # Brian
On Thu, Dec 19, 2013 at 06:05:18PM -0800, Brian Norris wrote: > On Thu, Dec 19, 2013 at 09:47:13PM -0300, Ezequiel Garcia wrote: > > On Fri, Dec 13, 2013 at 10:58:44AM -0300, Ezequiel Garcia wrote: > > > Make this option a hidden one and get a cleaner configuration. > > > This option just selects a common infrastructure for MTD-based devices > > > to expose a block interface. There is no point in allowing a separate > > > enable/disable. > > > > > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > > > --- > > > drivers/mtd/Kconfig | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > > > index 5fab4e6e..2a0ca2a 100644 > > > --- a/drivers/mtd/Kconfig > > > +++ b/drivers/mtd/Kconfig > > > @@ -158,9 +158,7 @@ config MTD_BCM47XX_PARTS > > > comment "User Modules And Translation Layers" > > > > > > config MTD_BLKDEVS > > > - tristate "Common interface to block layer for MTD 'translation layers'" > > > - depends on BLOCK > > > - default n > > > + bool > > > > > > config MTD_BLOCK > > > tristate "Caching block device access to MTD devices" > > > > Any comments on this one? > > It looks OK to me. I might add a comment above MTD_BLKDEVS like I see in > some other similar Kconfig not-user-selectable options: > > # > # MTD block device support is select'ed if needed > # > Fully agreed.
diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 5fab4e6e..2a0ca2a 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -158,9 +158,7 @@ config MTD_BCM47XX_PARTS comment "User Modules And Translation Layers" config MTD_BLKDEVS - tristate "Common interface to block layer for MTD 'translation layers'" - depends on BLOCK - default n + bool config MTD_BLOCK tristate "Caching block device access to MTD devices"
Make this option a hidden one and get a cleaner configuration. This option just selects a common infrastructure for MTD-based devices to expose a block interface. There is no point in allowing a separate enable/disable. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- drivers/mtd/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)