Patchwork net: KS8851 needs to depend on MII

login
register
mail settings
Submitter Alexander Beregalov
Date July 22, 2009, 11:16 a.m.
Message ID <1248261411-12533-1-git-send-email-a.beregalov@gmail.com>
Download mbox | patch
Permalink /patch/30075/
State Accepted
Delegated to: David Miller
Headers show

Comments

Alexander Beregalov - July 22, 2009, 11:16 a.m.
fix this build error when CONFIG_MII is not set
drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
 drivers/net/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Ben Dooks - July 22, 2009, 11:19 a.m.
Alexander Beregalov wrote:
> fix this build error when CONFIG_MII is not set
> drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
> drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
> drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
> drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
> drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'

thanks, my test system has an DM9000 so that selected CONFIG_MII for me.

> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: Ben Dooks <ben@simtec.co.uk>

> ---
>  drivers/net/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 1dbaffd..3ed49f1 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1732,6 +1732,7 @@ config KS8842
>  config KS8851
>         tristate "Micrel KS8851 SPI"
>         depends on SPI
> +       select MII
>         help
>           SPI driver for Micrel KS8851 SPI attached network chip.
>
David Miller - July 22, 2009, 4:33 p.m.
From: Ben Dooks <ben@simtec.co.uk>
Date: Wed, 22 Jul 2009 12:19:17 +0100

> Alexander Beregalov wrote:
>> fix this build error when CONFIG_MII is not set
>> drivers/net/ks8851.c:999: undefined reference to `generic_mii_ioctl'
>> drivers/net/ks8851.c:1050: undefined reference to `mii_link_ok'
>> drivers/net/ks8851.c:1056: undefined reference to `mii_nway_restart'
>> drivers/net/ks8851.c:1044: undefined reference to `mii_ethtool_sset'
>> drivers/net/ks8851.c:1038: undefined reference to `mii_ethtool_gset'
> 
> thanks, my test system has an DM9000 so that selected CONFIG_MII for
> me.
> 
>> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> Acked-by: Ben Dooks <ben@simtec.co.uk>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 1dbaffd..3ed49f1 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1732,6 +1732,7 @@  config KS8842
 config KS8851
        tristate "Micrel KS8851 SPI"
        depends on SPI
+       select MII
        help
          SPI driver for Micrel KS8851 SPI attached network chip.