diff mbox

ipv6: fix incorrect type in initializer

Message ID 1386844881-32017-1-git-send-email-florent.fourcot@enst-bretagne.fr
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Florent Fourcot Dec. 12, 2013, 10:41 a.m. UTC
Introduced by 1397ed35f22d7c30d0b89ba74b6b7829220dfcfd
  "ipv6: add flowinfo for tcp6 pkt_options for all cases"

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
---
 net/ipv6/ipv6_sockglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sergei Shtylyov Dec. 12, 2013, 2:36 p.m. UTC | #1
Hello.

On 12-12-2013 14:41, Florent Fourcot wrote:

    s/initializer/declaration/.

> Introduced by 1397ed35f22d7c30d0b89ba74b6b7829220dfcfd
>    "ipv6: add flowinfo for tcp6 pkt_options for all cases"

> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
> ---
>   net/ipv6/ipv6_sockglue.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
> index bc4d8a2..dac04d2 100644
> --- a/net/ipv6/ipv6_sockglue.c
> +++ b/net/ipv6/ipv6_sockglue.c
> @@ -1035,7 +1035,7 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname,
>   				put_cmsg(&msg, SOL_IPV6, IPV6_2292HOPLIMIT, sizeof(hlim), &hlim);
>   			}
>   			if (np->rxopt.bits.rxflow) {
> -				int flowinfo = np->rcv_flowinfo;
> +				__be32 flowinfo = np->rcv_flowinfo;

    Empty line wouldn't hurt here, after declaration.

>   				put_cmsg(&msg, SOL_IPV6, IPV6_FLOWINFO, sizeof(flowinfo), &flowinfo);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
index bc4d8a2..dac04d2 100644
--- a/net/ipv6/ipv6_sockglue.c
+++ b/net/ipv6/ipv6_sockglue.c
@@ -1035,7 +1035,7 @@  static int do_ipv6_getsockopt(struct sock *sk, int level, int optname,
 				put_cmsg(&msg, SOL_IPV6, IPV6_2292HOPLIMIT, sizeof(hlim), &hlim);
 			}
 			if (np->rxopt.bits.rxflow) {
-				int flowinfo = np->rcv_flowinfo;
+				__be32 flowinfo = np->rcv_flowinfo;
 				put_cmsg(&msg, SOL_IPV6, IPV6_FLOWINFO, sizeof(flowinfo), &flowinfo);
 			}
 		}