Message ID | 20090721181153.GA5970@gerrit.erg.abdn.ac.uk |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Gerrit Renker <gerrit@erg.abdn.ac.uk> Date: Tue, 21 Jul 2009 20:11:53 +0200 > mcastv6: Local variable shadows function argument > > The local variable 'idev' shadows the function argument 'idev' to > ip6_mc_add_src(). Fixed by removing the local declaration, as pmc->idev > should be identical with 'idev' passed as argument. > > Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> > Acked-by: David L Stevens <dlstevens@us.ibm.com> Applied to net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -2107,7 +2107,6 @@ static int ip6_mc_add_src(struct inet6_d for (j=0; j<i; j++) (void) ip6_mc_del1_src(pmc, sfmode, &psfsrc[i]); } else if (isexclude != (pmc->mca_sfcount[MCAST_EXCLUDE] != 0)) { - struct inet6_dev *idev = pmc->idev; struct ip6_sf_list *psf; /* filter mode change */