Patchwork [PULL,08/28] spapr_pci: s/INT64_MAX/UINT64_MAX/

mail settings
Submitter Michael S. Tsirkin
Date Dec. 11, 2013, 6:30 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/300268/
State New
Headers show


Michael S. Tsirkin - Dec. 11, 2013, 6:30 p.m.
It doesn't make sense for a region to be INT64_MAX in size:
memory core uses UINT64_MAX as a special value meaning
"all 64 bit" this is what was meant here.

While this should never affect the spapr system which at the moment always
has < 63 bit size, this makes us hit all kind of corner case bugs with
sub-pages, so users are probably better off if we just use UINT64_MAX

Signed-off-by: Michael S. Tsirkin <>
Acked-by: Alexander Graf <>
 hw/ppc/spapr_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index edb4cb0..2beedd4 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -555,7 +555,7 @@  static int spapr_phb_init(SysBusDevice *s)
     /* Initialize memory regions */
     sprintf(namebuf, "%s.mmio", sphb->dtbusname);
-    memory_region_init(&sphb->memspace, OBJECT(sphb), namebuf, INT64_MAX);
+    memory_region_init(&sphb->memspace, OBJECT(sphb), namebuf, UINT64_MAX);
     sprintf(namebuf, "%s.mmio-alias", sphb->dtbusname);
     memory_region_init_alias(&sphb->memwindow, OBJECT(sphb),