From patchwork Wed Dec 11 12:00:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 300021 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 723432C00A4 for ; Wed, 11 Dec 2013 23:00:31 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1VqiSs-0007Zr-9Y; Wed, 11 Dec 2013 12:00:30 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1VqiSh-0007Qd-Ux for fwts-devel@lists.ubuntu.com; Wed, 11 Dec 2013 12:00:20 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginm.net ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1VqiSh-0003uZ-Pt for fwts-devel@lists.ubuntu.com; Wed, 11 Dec 2013 12:00:19 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] cpu: microcode: test should skip if no microcound found (LP: #1259900) Date: Wed, 11 Dec 2013 12:00:19 +0000 Message-Id: <1386763219-11889-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.5.1 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King If microcode is not found we should skip the test rather than not report a pass or fail. Signed-off-by: Colin Ian King Acked-by: Ivan Hu Acked-by: Alex Hung --- src/cpu/microcode/microcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c index 8794c6c..d9dad9b 100644 --- a/src/cpu/microcode/microcode.c +++ b/src/cpu/microcode/microcode.c @@ -288,7 +288,7 @@ static int microcode_test1(fwts_framework *fw) if (passed > 0) fwts_passed(fw, "%d CPU(s) have the latest microcode loaded.", passed); else - fwts_log_info(fw, "Could not determine from kernel log if latest microcode has been loaded."); + fwts_skipped(fw, "Could not determine from kernel log if latest microcode has been loaded."); } closedir(dir);