Patchwork [5/5] Makefile.in: allow make install e4defrag

login
register
mail settings
Submitter Peng Tao
Date July 20, 2009, 4:21 a.m.
Message ID <4A63F0B1.7090002@gmail.com>
Download mbox | patch
Permalink /patch/29997/
State New
Headers show

Comments

Peng Tao - July 20, 2009, 4:21 a.m.
Hi, Eric
Eric Sandeen wrote:
> Peng Tao wrote:
>> Current Makefile does not install e4defrag nor e4defrag.8.
>> Change misc/Makefile.in to make the e4defrag available for use.
>>
>> Signed-off-by: Peng Tao <bergwolf@gmail.com>
> 
> Since this is all still fairly developmental at this point (I think?)
> perhaps a special "make install-e4defrag" target might be best.
> 
> Otherwise packages which "make install" will start shipping e4defrag,
> and I'm not sure we want to do that quite yet.
Thanks for your reviewing. Does the following patch meet your expectation?

From 248322ee72e371dcd1b302400d787f9f2eec15cd Mon Sep 17 00:00:00 2001
From: Peng Tao <bergwolf@gmail.com>
Date: Mon, 20 Jul 2009 12:01:55 +0800
Subject: [PATCH-e2fsprogs] Makefile.in: add install-e4defrag target

The e4defrag program is still developmental, but we can make it available
for use if someone wants to test it.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
---
 Makefile.in      |    3 +++
 misc/Makefile.in |    6 +++++-
 2 files changed, 8 insertions(+), 1 deletions(-)
Eric Sandeen - July 20, 2009, 2:52 p.m.
Peng Tao wrote:

> From 248322ee72e371dcd1b302400d787f9f2eec15cd Mon Sep 17 00:00:00 2001
> From: Peng Tao <bergwolf@gmail.com>
> Date: Mon, 20 Jul 2009 12:01:55 +0800
> Subject: [PATCH-e2fsprogs] Makefile.in: add install-e4defrag target
> 
> The e4defrag program is still developmental, but we can make it available
> for use if someone wants to test it.
> 
> Signed-off-by: Peng Tao <bergwolf@gmail.com>

I like this better, thanks!  I'll ask on the ext4 call today if others
concur.

-Eric

> ---
>  Makefile.in      |    3 +++
>  misc/Makefile.in |    6 +++++-
>  2 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile.in b/Makefile.in
> index 45f2972..1c2b44e 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -57,6 +57,9 @@ clean-doc:
>  distclean-doc:
>  	-test -d doc && cd doc && $(MAKE) distclean
>  
> +install-e4defrag: subs all-libs-recursive
> +	$(MAKE) -C misc install-e4defrag
> +
>  install: subs all-libs-recursive install-progs-recursive \
>    install-shlibs-libs-recursive install-doc-libs
>  	if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d ext2ed ; then $(MAKE) install-libs ; fi
> diff --git a/misc/Makefile.in b/misc/Makefile.in
> index 5f5dab5..029a201 100644
> --- a/misc/Makefile.in
> +++ b/misc/Makefile.in
> @@ -399,6 +399,10 @@ installdirs:
>  		$(DESTDIR)$(man1dir) $(DESTDIR)$(man5dir) \
>  		$(DESTDIR)$(libdir) $(DESTDIR)/$(root_sysconfdir)
>  
> +install-e4defrag: e4defrag e4defrag.8 installdirs
> +	$(INSTALL_PROGRAM) e4defrag $(DESTDIR)$(bindir)/e4defrag
> +	$(INSTALL_DATA) e4defrag.8 $(DESTDIR)$(man8dir)/e4defrag.8
> +
>  install: all $(SMANPAGES) $(UMANPAGES) installdirs
>  	$(Q) for i in $(SPROGS); do \
>  		echo "	INSTALL $(root_sbindir)/$$i"; \
> @@ -556,7 +560,7 @@ clean:
>  		blkid.profiled tune2fs.profiled e2image.profiled \
>  		e2undo.profiled mke2fs.profiled dumpe2fs.profiled \
>  		logsave.profiled filefrag.profiled uuidgen.profiled \
> -		uuidd.profiled e2image.profiled \
> +		uuidd.profiled e2image.profiled e4defrag \
>  		profiled/*.o \#* *.s *.o *.a *~ core gmon.out
>  
>  mostlyclean: clean

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Makefile.in b/Makefile.in
index 45f2972..1c2b44e 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -57,6 +57,9 @@  clean-doc:
 distclean-doc:
 	-test -d doc && cd doc && $(MAKE) distclean
 
+install-e4defrag: subs all-libs-recursive
+	$(MAKE) -C misc install-e4defrag
+
 install: subs all-libs-recursive install-progs-recursive \
   install-shlibs-libs-recursive install-doc-libs
 	if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d ext2ed ; then $(MAKE) install-libs ; fi
diff --git a/misc/Makefile.in b/misc/Makefile.in
index 5f5dab5..029a201 100644
--- a/misc/Makefile.in
+++ b/misc/Makefile.in
@@ -399,6 +399,10 @@  installdirs:
 		$(DESTDIR)$(man1dir) $(DESTDIR)$(man5dir) \
 		$(DESTDIR)$(libdir) $(DESTDIR)/$(root_sysconfdir)
 
+install-e4defrag: e4defrag e4defrag.8 installdirs
+	$(INSTALL_PROGRAM) e4defrag $(DESTDIR)$(bindir)/e4defrag
+	$(INSTALL_DATA) e4defrag.8 $(DESTDIR)$(man8dir)/e4defrag.8
+
 install: all $(SMANPAGES) $(UMANPAGES) installdirs
 	$(Q) for i in $(SPROGS); do \
 		echo "	INSTALL $(root_sbindir)/$$i"; \
@@ -556,7 +560,7 @@  clean:
 		blkid.profiled tune2fs.profiled e2image.profiled \
 		e2undo.profiled mke2fs.profiled dumpe2fs.profiled \
 		logsave.profiled filefrag.profiled uuidgen.profiled \
-		uuidd.profiled e2image.profiled \
+		uuidd.profiled e2image.profiled e4defrag \
 		profiled/*.o \#* *.s *.o *.a *~ core gmon.out
 
 mostlyclean: clean